From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Nikhil Rao <nikhil.rao@intel.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org, stable@dpdk.org, sunila.sahu@caviumnetworks.com,
rasesh.mody@cavium.com, roy.fan.zhang@intel.com
Subject: Re: [dpdk-stable] [PATCH] eventdev: prefix global variable
Date: Fri, 5 Oct 2018 09:55:24 +0100 [thread overview]
Message-ID: <f007e2ae-b112-f3c0-7448-3db1ef0e9f30@intel.com> (raw)
In-Reply-To: <20181003134811.64662-1-ferruh.yigit@intel.com>
On 10/3/2018 2:48 PM, Ferruh Yigit wrote:
> A global defined with name "stats".
>
> DPDK is a library, please don't define global variables with this
> generic name.
>
> Fixes: b1ce8ebd97ba ("eventdev: add PMD callbacks for eth Rx adapter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> There are already questions about that "stats" variable:
> - Why a global variable defined in header file?
> - It seems it is not used at all, remove it?
> Forgotten to be removed in below commit, but because of generic
> "stats" name, it didn't cause any compile error but happily used
> global variable
> Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter")
>
> But this patch mainly sent as an RFC, to ask what would you think about
> a cleanup patch to add the library prefix for all the global variables
> that are defined in libries? (yes we have lots of them)
>
> Like:
> zip_cc --> octeontx_zip_cc [1]
> valid_args --> qede_valid_args [2]
> scheduler --> crypto_scheduler [3]
The cleanup patch has been sent:
"fix static variables"
https://patches.dpdk.org/patch/46006/
This patch has been superseded by above one.
prev parent reply other threads:[~2018-10-05 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 13:48 Ferruh Yigit
2018-10-05 8:55 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f007e2ae-b112-f3c0-7448-3db1ef0e9f30@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=nikhil.rao@intel.com \
--cc=rasesh.mody@cavium.com \
--cc=roy.fan.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=sunila.sahu@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).