From: "Doherty, Declan" <declan.doherty@intel.com>
To: dev@dpdk.org, pablo.de.lara.guarch@intel.com,
jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com,
roy.fan.zhang@intel.com, fiona.trahe@intel.com,
jblunck@infradead.org, jianfeng.tan@intel.com
Subject: Re: [dpdk-dev] [PATCH 0/3] Break dependency on bus infrastructure*
Date: Mon, 23 Oct 2017 10:21:03 +0100 [thread overview]
Message-ID: <f0667a19-e015-e247-ac87-242cfa2bdada@intel.com> (raw)
In-Reply-To: <20171020212113.4543-1-declan.doherty@intel.com>
Hey folks,
to assist in the work of moving the PCI
(http://dpdk.org/ml/archives/dev/2017-October/078803.html) and virtual
bus (http://dpdk.org/ml/archives/dev/2017-October/077858.html,
http://dpdk.org/ml/archives/dev/2017-October/078783.html) out of EAL
I've put together this patch set which I think gives a clearer approach
to breaking the dependency which the cryptodev library had on the bus
infrastructure. It also allows the removal of some replicate boiler
plate code in the crypto PMDs. Please have a look and make sure that I
haven't introduced any problems to your respective PMDs.
Regards
Declan
On 20/10/2017 10:21 PM, Declan Doherty wrote:
> This patch set breaks the dependency of the cryptodev library on both the
> virtual and PCI device infrastructure.
>
> It introduces new bus independent crypto PMD driver assist functions for
> parsing initialisation parameters, and creation/destruction of device
> instances.
>
> It deprecates all function calls to the bus dependent functions and
> updates all crypto PMDs to use the newly introduced device independent
> functions.
>
> Declan Doherty (3):
> cryptodev: add new APIs to assist PMD initialisation
> cryptodev: break dependency on virtual device bus
> cryptodev: break dependency on rte_pci.h
>
> doc/guides/rel_notes/deprecation.rst | 6 +
> drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 55 +++-----
> drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 72 +++++-----
> drivers/crypto/armv8/rte_armv8_pmd.c | 41 ++----
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 11 +-
> drivers/crypto/dpaa_sec/dpaa_sec.c | 14 +-
> drivers/crypto/kasumi/rte_kasumi_pmd.c | 47 +++----
> drivers/crypto/mrvl/rte_mrvl_pmd.c | 56 +++-----
> drivers/crypto/null/null_crypto_pmd.c | 72 ++++------
> drivers/crypto/openssl/rte_openssl_pmd.c | 42 ++----
> drivers/crypto/qat/qat_crypto.c | 3 +-
> drivers/crypto/qat/rte_qat_cryptodev.c | 55 ++++++--
> drivers/crypto/scheduler/scheduler_pmd.c | 45 ++----
> drivers/crypto/scheduler/scheduler_pmd_ops.c | 3 +-
> drivers/crypto/snow3g/rte_snow3g_pmd.c | 41 ++----
> drivers/crypto/zuc/rte_zuc_pmd.c | 41 +++---
> lib/librte_cryptodev/Makefile | 2 -
> lib/librte_cryptodev/rte_cryptodev.h | 8 +-
> lib/librte_cryptodev/rte_cryptodev_pci.h | 92 -------------
> lib/librte_cryptodev/rte_cryptodev_pmd.c | 184 ++++++++++---------------
> lib/librte_cryptodev/rte_cryptodev_pmd.h | 88 ++++++++++++
> lib/librte_cryptodev/rte_cryptodev_vdev.h | 100 --------------
> lib/librte_cryptodev/rte_cryptodev_version.map | 7 +-
> 23 files changed, 405 insertions(+), 680 deletions(-)
> delete mode 100644 lib/librte_cryptodev/rte_cryptodev_pci.h
> delete mode 100644 lib/librte_cryptodev/rte_cryptodev_vdev.h
>
next prev parent reply other threads:[~2017-10-23 9:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 21:21 Declan Doherty
2017-10-20 21:21 ` [dpdk-dev] [PATCH 1/3] cryptodev: add new APIs to assist PMD initialisation Declan Doherty
2017-10-24 11:03 ` De Lara Guarch, Pablo
2017-10-24 14:09 ` Tomasz Duszynski
2017-10-25 0:59 ` Gaëtan Rivet
2017-10-20 21:21 ` [dpdk-dev] [PATCH 2/3] cryptodev: break dependency on virtual device bus Declan Doherty
2017-10-24 11:18 ` De Lara Guarch, Pablo
2017-10-24 11:32 ` Akhil Goyal
2017-10-25 6:18 ` Tomasz Duszynski
2017-10-25 7:45 ` De Lara Guarch, Pablo
2017-10-20 21:21 ` [dpdk-dev] [PATCH 3/3] cryptodev: break dependency on rte_pci.h Declan Doherty
2017-10-24 11:23 ` De Lara Guarch, Pablo
2017-10-23 9:21 ` Doherty, Declan [this message]
2017-10-25 0:50 ` [dpdk-dev] [PATCH 0/3] Break dependency on bus infrastructure* Gaëtan Rivet
2017-10-25 12:00 ` [dpdk-dev] [PATCH v2 0/3] Break cryptodev dependency on bus infrastructure Declan Doherty
2017-10-25 12:00 ` [dpdk-dev] [PATCH v2 1/3] cryptodev: add new APIs to assist PMD initialisation Declan Doherty
2017-10-25 15:56 ` Trahe, Fiona
2017-10-25 12:00 ` [dpdk-dev] [PATCH v2 2/3] cryptodev: break dependency on virtual device bus Declan Doherty
2017-10-25 12:00 ` [dpdk-dev] [PATCH v2 3/3] cryptodev: break dependency on PCI " Declan Doherty
2017-10-25 15:55 ` Trahe, Fiona
2017-10-25 14:36 ` [dpdk-dev] [PATCH v2 0/3] Break cryptodev dependency on bus infrastructure De Lara Guarch, Pablo
2017-10-25 16:06 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0667a19-e015-e247-ac87-242cfa2bdada@intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jblunck@infradead.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianfeng.tan@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).