From: Ferruh Yigit <ferruh.yigit@amd.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: stable@dpdk.org, "Luca Boccassi" <luca.boccassi@microsoft.com>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Abdullah Ömer Yamaç" <omer.yamac@ceng.metu.edu.tr>
Subject: Re: [PATCH] drivers: fix symbol exports when map is omitted
Date: Tue, 29 Nov 2022 18:23:21 +0000 [thread overview]
Message-ID: <f1c5cbed-e40b-ba80-98ac-b5385f612b6b@amd.com> (raw)
In-Reply-To: <20221129140032.35940-1-david.marchand@redhat.com>
On 11/29/2022 2:00 PM, David Marchand wrote:
> ld exports any global symbol by default if no version script is passed.
> As a consequence, the incriminated change let any public symbol leak
> out of the driver shared libraries.
>
> Hide again those symbols by providing a default map file which
> unexports any global symbol using a local: * catchall statement.
>
I assume this will cause warnings for ABI check scripts, how can we
prevent the warnings?
> The check on symbols is skipped for this default map file as it is
> intentionnally an empty map (see commit b67bdda86cd4 ("devtools: catch
> empty symbol maps")) and there is nothing to check in it.
>
How it is skipped, './devtools/check-symbol-maps.sh' still complains
about 'drivers/version.map' for me.
> While at it, move Windows specific objects where needed for better
> readability.
>
+1
> Fixes: 7dde9c844a37 ("drivers: omit symbol map when unneeded")
> Cc: stable@dpdk.org
>
> Reported-by: Luca Boccassi <luca.boccassi@microsoft.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Not tested on Windows, but for Linux:
Tested-by: Ferruh Yigit <ferruh.yigit@amd.com>
next prev parent reply other threads:[~2022-11-29 18:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 14:00 David Marchand
2022-11-29 18:23 ` Ferruh Yigit [this message]
2022-11-30 7:13 ` David Marchand
2022-11-30 8:27 ` David Marchand
2022-11-30 9:19 ` Ferruh Yigit
2022-12-02 0:11 ` Tyler Retzlaff
2022-11-30 10:02 ` [PATCH v2] " David Marchand
2022-11-30 10:44 ` Ferruh Yigit
2022-11-30 15:02 ` David Marchand
2022-11-30 15:24 ` David Marchand
2022-11-30 15:42 ` Bruce Richardson
2022-12-01 10:11 ` David Marchand
2022-12-01 10:08 ` [PATCH v3 1/2] " David Marchand
2022-12-01 10:55 ` Bruce Richardson
2022-12-02 10:01 ` David Marchand
2022-12-02 11:09 ` [PATCH v4 " David Marchand
2022-12-02 13:39 ` Aaron Conole
2022-12-05 10:23 ` David Marchand
2022-12-05 10:43 ` [EXT] " Akhil Goyal
2022-12-05 12:36 ` David Marchand
2022-12-05 13:47 ` Akhil Goyal
2022-12-05 15:37 ` Thomas Monjalon
2022-12-05 16:26 ` Akhil Goyal
2022-12-06 10:12 ` Ferruh Yigit
2022-12-06 10:18 ` David Marchand
2022-12-06 12:25 ` Ferruh Yigit
2022-12-07 18:00 ` Patrick Robb
2022-12-08 13:22 ` Thomas Monjalon
2022-12-08 16:06 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1c5cbed-e40b-ba80-98ac-b5385f612b6b@amd.com \
--to=ferruh.yigit@amd.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=luca.boccassi@microsoft.com \
--cc=omer.yamac@ceng.metu.edu.tr \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).