From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/kni: add KNI PMD
Date: Thu, 8 Sep 2016 19:11:31 +0100 [thread overview]
Message-ID: <f204ba35-b5e7-4fb5-d51d-5d286dd041db@intel.com> (raw)
In-Reply-To: <1794333.caoKPGO1RT@xps13>
On 9/8/2016 10:38 AM, Thomas Monjalon wrote:
> 2016-09-08 10:25, Bruce Richardson:
>> On Thu, Sep 08, 2016 at 09:44:55AM +0200, Thomas Monjalon wrote:
>>> 2016-09-06 11:33, Ferruh Yigit:
>>>> Add KNI PMD which wraps librte_kni for ease of use.
>>>>
>>>> KNI PMD can be used as any regular PMD to send / receive packets to the
>>>> Linux networking stack.
>>>
>>> Good move!
>>> Why not deprecate librte_kni and move all the code in the PMD later?
>>
>> +1 to this plan. However, I don't think it all needs to be done in one patchset,
>> though, does it?
>
> I think the deprecation notice must be in this patchset along with some
> __rte_deprecated in front of librte_kni functions.
> Then the move of the library in the PMD could be done in the next release.
>
Not sure about deprecating librte_kni, this means existing KNI
applications needs to be updated. What is the benefit of this effort?
Also librte_kni supports more than what PMD does, like PMD doesn't have
ethtool support or binding kernel threads, it uses hardcoded mbuf_size...
I was thinking PMD as a data only, simplified use case of library.
Regards,
ferruh
next prev parent reply other threads:[~2016-09-08 18:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 10:33 Ferruh Yigit
2016-09-08 7:44 ` Thomas Monjalon
2016-09-08 9:25 ` Bruce Richardson
2016-09-08 9:38 ` Thomas Monjalon
2016-09-08 18:11 ` Ferruh Yigit [this message]
2016-09-09 7:36 ` Thomas Monjalon
2016-09-16 11:29 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2016-10-10 13:19 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2016-11-03 1:24 ` Yong Wang
2016-11-04 12:21 ` Ferruh Yigit
2016-11-30 18:12 ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2016-12-12 21:59 ` Yong Wang
2016-12-14 15:59 ` Ferruh Yigit
2016-12-14 19:25 ` Yong Wang
2016-12-15 15:55 ` Ferruh Yigit
2016-12-19 17:52 ` Yong Wang
2017-01-30 16:57 ` [dpdk-dev] [PATCH v5] " Ferruh Yigit
2017-01-30 19:05 ` Yong Wang
2017-01-30 19:43 ` Ferruh Yigit
2017-01-30 20:09 ` [dpdk-dev] [PATCH v6] " Ferruh Yigit
2017-01-30 21:15 ` [dpdk-dev] [PATCH v7] " Ferruh Yigit
2017-01-31 12:18 ` [dpdk-dev] [PATCH v8] " Ferruh Yigit
2017-02-17 13:42 ` [dpdk-dev] [PATCH v9] " Ferruh Yigit
2017-02-17 13:47 ` Thomas Monjalon
2017-02-17 14:00 ` Eelco Chaudron
2017-02-17 14:29 ` Ferruh Yigit
2017-02-17 14:57 ` Bruce Richardson
2017-02-17 17:52 ` Yong Wang
2017-02-17 22:37 ` Thomas Monjalon
2017-02-20 12:54 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f204ba35-b5e7-4fb5-d51d-5d286dd041db@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).