From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Vijay Srivastava <vijays@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/8] common/sfc_efx/base: add base virtio support for vDPA
Date: Tue, 16 Mar 2021 15:14:35 +0300 [thread overview]
Message-ID: <f24a597d-ce45-f16b-1c0b-f27ab28e1406@oktetlabs.ru> (raw)
In-Reply-To: <aeb04050-bab7-8b0f-43ca-44864e2aa8a4@intel.com>
On 3/16/21 2:58 PM, Ferruh Yigit wrote:
> On 3/16/2021 11:47 AM, Andrew Rybchenko wrote:
>> On 3/16/21 2:30 PM, Ferruh Yigit wrote:
>>> On 3/16/2021 8:58 AM, Andrew Rybchenko wrote:
>>>> From: Vijay Srivastava <vijays@solarflare.com>
>>>>
>>>> In the vDPA mode, only data path is offloaded in the hardware and
>>>> control path still goes through the hypervisor and it configures
>>>> virtqueues via vDPA driver so new virtqueue APIs are required.
>>>>
>>>> Implement virtio init/fini and virtqueue create/destroy APIs.
>>>>
>>>> Signed-off-by: Vijay Srivastava <vijays@solarflare.com>
>>>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>>
>>> <...>
>>>
>>>> diff --git a/drivers/common/sfc_efx/efsys.h
>>>> b/drivers/common/sfc_efx/efsys.h
>>>> index 663601412e..d133d61b3d 100644
>>>> --- a/drivers/common/sfc_efx/efsys.h
>>>> +++ b/drivers/common/sfc_efx/efsys.h
>>>> @@ -187,6 +187,8 @@ prefetch_read_once(const volatile void *addr)
>>>> #define EFSYS_OPT_MAE 1
>>>> +#define EFSYS_OPT_VIRTIO 0
>>>> +
>>>
>>> Hi Andrew,
>>>
>>> How this 'efsys.h' works, is it compile time configuration file for the
>>> driver?
>>
>> Yes, it is a compile time configuration of the base driver.
>>
>>> Is is expected that users change this file?
>>
>> Client drivers (e.g. net/sfc or vdpa/sfc) change the base
>> driver configuration when it needs corresponding functionality
>> from the base driver. Of course, it is not ideal to add code
>> which is not actually compiled right now, but we always try
>> to ensure that build finally works fine and no extra patches
>> will be required to fix the build when corresponding option
>> is enabled.
>>
>> In theory we can send longer patch series which includes
>> the vdpa/sfc driver, but it will be longer patch series which
>> is harder to chew.
>>
>
> It is OK to send preparation sets first, that wasn't my point.
I see.
> My concern is having compile time configuration within driver, my
> question is if end user of the driver need to tweak these config
> options, if so should it be more generic way instead of a PMD specific
> way...
No, it is not a user configuration. It is configuration done by
client (net/sfc, vdpa/sfc) drivers which use the common driver.
next prev parent reply other threads:[~2021-03-16 12:14 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 11:03 [dpdk-dev] [PATCH 0/8] common/sfc_efx: prepare to introduce vDPA driver Andrew Rybchenko
2021-03-11 11:03 ` [dpdk-dev] [PATCH 1/8] common/sfc_efx/base: add base virtio support for vDPA Andrew Rybchenko
2021-03-11 11:03 ` [dpdk-dev] [PATCH 2/8] common/sfc_efx/base: add API to get VirtQ doorbell offset Andrew Rybchenko
2021-03-11 11:03 ` [dpdk-dev] [PATCH 3/8] common/sfc_efx/base: add virtio build dependency Andrew Rybchenko
2021-03-11 11:03 ` [dpdk-dev] [PATCH 4/8] common/sfc_efx/base: add support to get virtio features Andrew Rybchenko
2021-03-11 11:03 ` [dpdk-dev] [PATCH 5/8] common/sfc_efx/base: add support to verify " Andrew Rybchenko
2021-03-11 11:03 ` [dpdk-dev] [PATCH 6/8] common/sfc_efx: add support to get the device class Andrew Rybchenko
2021-03-11 11:03 ` [dpdk-dev] [PATCH 7/8] net/sfc: skip driver probe for incompatible " Andrew Rybchenko
2021-03-11 11:03 ` [dpdk-dev] [PATCH 8/8] drivers: add common driver API to get efx family Andrew Rybchenko
2021-03-14 0:36 ` Ferruh Yigit
2021-03-15 14:01 ` Andrew Rybchenko
2021-03-15 13:58 ` [dpdk-dev] [PATCH v2 0/8] common/sfc_efx: prepare to introduce vDPA driver Andrew Rybchenko
2021-03-15 13:58 ` [dpdk-dev] [PATCH v2 1/8] common/sfc_efx/base: add base virtio support for vDPA Andrew Rybchenko
2021-03-15 13:58 ` [dpdk-dev] [PATCH v2 2/8] common/sfc_efx/base: add API to get VirtQ doorbell offset Andrew Rybchenko
2021-03-15 13:58 ` [dpdk-dev] [PATCH v2 3/8] common/sfc_efx/base: add virtio build dependency Andrew Rybchenko
2021-03-15 13:58 ` [dpdk-dev] [PATCH v2 4/8] common/sfc_efx/base: add support to get virtio features Andrew Rybchenko
2021-03-15 13:58 ` [dpdk-dev] [PATCH v2 5/8] common/sfc_efx/base: add support to verify " Andrew Rybchenko
2021-03-15 13:58 ` [dpdk-dev] [PATCH v2 6/8] common/sfc_efx: add support to get the device class Andrew Rybchenko
2021-03-15 13:58 ` [dpdk-dev] [PATCH v2 7/8] net/sfc: skip driver probe for incompatible " Andrew Rybchenko
2021-03-15 13:58 ` [dpdk-dev] [PATCH v2 8/8] drivers: add common driver API to get efx family Andrew Rybchenko
2021-03-15 15:54 ` [dpdk-dev] [PATCH v2 0/8] common/sfc_efx: prepare to introduce vDPA driver Ferruh Yigit
2021-03-16 7:25 ` Andrew Rybchenko
2021-03-16 6:15 ` [dpdk-dev] [PATCH v3 " Andrew Rybchenko
2021-03-16 6:15 ` [dpdk-dev] [PATCH v3 1/8] common/sfc_efx/base: add base virtio support for vDPA Andrew Rybchenko
2021-03-16 6:15 ` [dpdk-dev] [PATCH v3 2/8] common/sfc_efx/base: add API to get VirtQ doorbell offset Andrew Rybchenko
2021-03-16 6:15 ` [dpdk-dev] [PATCH v3 3/8] common/sfc_efx/base: add virtio build dependency Andrew Rybchenko
2021-03-16 6:15 ` [dpdk-dev] [PATCH v3 4/8] common/sfc_efx/base: add support to get virtio features Andrew Rybchenko
2021-03-16 6:15 ` [dpdk-dev] [PATCH v3 5/8] common/sfc_efx/base: add support to verify " Andrew Rybchenko
2021-03-16 6:15 ` [dpdk-dev] [PATCH v3 6/8] common/sfc_efx: add support to get the device class Andrew Rybchenko
2021-03-16 6:15 ` [dpdk-dev] [PATCH v3 7/8] net/sfc: skip driver probe for incompatible " Andrew Rybchenko
2021-03-16 6:15 ` [dpdk-dev] [PATCH v3 8/8] drivers: add common driver API to get efx family Andrew Rybchenko
2021-03-16 8:55 ` [dpdk-dev] [PATCH v3 0/8] common/sfc_efx: prepare to introduce vDPA driver Andrew Rybchenko
2021-03-16 8:58 ` [dpdk-dev] [PATCH v4 " Andrew Rybchenko
2021-03-16 8:58 ` [dpdk-dev] [PATCH v4 1/8] common/sfc_efx/base: add base virtio support for vDPA Andrew Rybchenko
2021-03-16 11:30 ` Ferruh Yigit
2021-03-16 11:47 ` Andrew Rybchenko
2021-03-16 11:58 ` Ferruh Yigit
2021-03-16 12:14 ` Andrew Rybchenko [this message]
2021-03-16 12:41 ` Ferruh Yigit
2021-03-16 8:58 ` [dpdk-dev] [PATCH v4 2/8] common/sfc_efx/base: add API to get VirtQ doorbell offset Andrew Rybchenko
2021-03-16 8:58 ` [dpdk-dev] [PATCH v4 3/8] common/sfc_efx/base: add virtio build dependency Andrew Rybchenko
2021-03-16 8:58 ` [dpdk-dev] [PATCH v4 4/8] common/sfc_efx/base: add support to get virtio features Andrew Rybchenko
2021-03-16 8:58 ` [dpdk-dev] [PATCH v4 5/8] common/sfc_efx/base: add support to verify " Andrew Rybchenko
2021-03-16 8:58 ` [dpdk-dev] [PATCH v4 6/8] common/sfc_efx: add support to get the device class Andrew Rybchenko
2021-03-16 8:58 ` [dpdk-dev] [PATCH v4 7/8] net/sfc: skip driver probe for incompatible " Andrew Rybchenko
2021-03-16 8:58 ` [dpdk-dev] [PATCH v4 8/8] drivers: add common driver API to get efx family Andrew Rybchenko
2021-03-16 11:26 ` [dpdk-dev] [PATCH v4 0/8] common/sfc_efx: prepare to introduce vDPA driver Ferruh Yigit
2021-03-16 11:30 ` Andrew Rybchenko
2021-03-16 11:32 ` Ferruh Yigit
2021-03-16 11:34 ` Ferruh Yigit
2021-03-16 11:46 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f24a597d-ce45-f16b-1c0b-f27ab28e1406@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=vijays@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).