From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, anatoly.burakov@intel.com
Subject: [dpdk-dev] [PATCH 4/4] fbarray: handle negative return
Date: Tue, 17 Apr 2018 16:44:08 +0100 [thread overview]
Message-ID: <f2555604cb64ab2306b8b6ace40893c7be31c4dc.1523978190.git.anatoly.burakov@intel.com> (raw)
In-Reply-To: <cover.1523978190.git.anatoly.burakov@intel.com>
In-Reply-To: <cover.1523978190.git.anatoly.burakov@intel.com>
sysconf() may return a negative value, check for it.
Coverity issue: 272586
Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
Cc: anatoly.burakov@intel.com
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/common/eal_common_fbarray.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_eal/common/eal_common_fbarray.c b/lib/librte_eal/common/eal_common_fbarray.c
index c4ed97e..6486679 100644
--- a/lib/librte_eal/common/eal_common_fbarray.c
+++ b/lib/librte_eal/common/eal_common_fbarray.c
@@ -561,6 +561,9 @@ rte_fbarray_detach(struct rte_fbarray *arr)
size_t page_sz = sysconf(_SC_PAGESIZE);
+ if (page_sz == (size_t)-1)
+ return -1;
+
/* this may already be unmapped (e.g. repeated call from previously
* failed destroy(), but this is on user, we can't (easily) know if this
* is still mapped.
--
2.7.4
next prev parent reply other threads:[~2018-04-17 15:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 15:44 [dpdk-dev] [PATCH 0/4] Fixes for coverity issues in fbarray Anatoly Burakov
2018-04-17 15:44 ` [dpdk-dev] [PATCH 1/4] fbarray: use strlcpy instead of snprintf Anatoly Burakov
2018-04-17 15:44 ` [dpdk-dev] [PATCH 2/4] fbarray: add check for failed file descriptor open Anatoly Burakov
2018-04-17 15:44 ` [dpdk-dev] [PATCH 3/4] fbarray: fix potential null-dereference Anatoly Burakov
2018-04-17 15:44 ` Anatoly Burakov [this message]
2018-04-18 8:51 ` [dpdk-dev] [PATCH 0/4] Fixes for coverity issues in fbarray Adrien Mazarguil
2018-04-23 20:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2555604cb64ab2306b8b6ace40893c7be31c4dc.1523978190.git.anatoly.burakov@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).