From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Cc: Andy Moreton <amoreton@solarflare.com>, <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 15/53] net/sfc/base: fix PreFAST issues
Date: Tue, 28 Nov 2017 14:49:04 +0300 [thread overview]
Message-ID: <f2e1de70-4acf-db91-527e-37c0e436c78b@solarflare.com> (raw)
In-Reply-To: <bb8dffb3-7a36-9d09-9f8f-c9a8a98285ad@intel.com>
On 11/27/2017 10:58 PM, Ferruh Yigit wrote:
> On 11/16/2017 12:04 AM, Andrew Rybchenko wrote:
>> From: Andy Moreton <amoreton@solarflare.com>
>>
> PREfast seems a static analysis tool. Can you please give more detail about
> fixed issue itself. "fix PREfast issue" is not informative about what has been
> fixed.
>
> If you can send the details I can amend the commit.
Add missing annotation that function return value should not be
ignored. Fix alignment.
Thanks,
Andrew.
>
> Thanks,
> ferruh
>
>> Fixes: 19b64c6ac35f ("net/sfc/base: import libefx base")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Andy Moreton <amoreton@solarflare.com>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>> drivers/net/sfc/base/efx.h | 12 ++++++------
>> drivers/net/sfc/base/efx_phy.c | 2 +-
>> 2 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h
>> index 834eea0..ca0f945 100644
>> --- a/drivers/net/sfc/base/efx.h
>> +++ b/drivers/net/sfc/base/efx.h
>> @@ -913,13 +913,13 @@ efx_phy_media_type_get(
>> __in efx_nic_t *enp,
>> __out efx_phy_media_type_t *typep);
>>
>> -extern efx_rc_t
>> +extern __checkReturn efx_rc_t
>> efx_phy_module_get_info(
>> - __in efx_nic_t *enp,
>> - __in uint8_t dev_addr,
>> - __in uint8_t offset,
>> - __in uint8_t len,
>> - __out_bcount(len) uint8_t *data);
>> + __in efx_nic_t *enp,
>> + __in uint8_t dev_addr,
>> + __in uint8_t offset,
>> + __in uint8_t len,
>> + __out_bcount(len) uint8_t *data);
>>
>> #if EFSYS_OPT_PHY_STATS
>>
>> diff --git a/drivers/net/sfc/base/efx_phy.c b/drivers/net/sfc/base/efx_phy.c
>> index 752cd52..c81a91c 100644
>> --- a/drivers/net/sfc/base/efx_phy.c
>> +++ b/drivers/net/sfc/base/efx_phy.c
>> @@ -296,7 +296,7 @@ efx_phy_media_type_get(
>> *typep = epp->ep_fixed_port_type;
>> }
>>
>> - __checkReturn efx_rc_t
>> + __checkReturn efx_rc_t
>> efx_phy_module_get_info(
>> __in efx_nic_t *enp,
>> __in uint8_t dev_addr,
>>
next prev parent reply other threads:[~2017-11-28 11:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1510819481-6809-1-git-send-email-arybchenko@solarflare.com>
2017-11-16 8:03 ` [dpdk-stable] [PATCH 03/53] net/sfc/base: fix result code in MCDI NVRAM update finish Andrew Rybchenko
2017-11-16 8:03 ` [dpdk-stable] [PATCH 11/53] net/sfc/base: fix check in NVRAM validate Andrew Rybchenko
2017-11-16 8:04 ` [dpdk-stable] [PATCH 15/53] net/sfc/base: fix PreFAST issues Andrew Rybchenko
2017-11-27 19:58 ` Ferruh Yigit
2017-11-28 11:49 ` Andrew Rybchenko [this message]
2017-11-16 8:04 ` [dpdk-stable] [PATCH 34/53] net/sfc/base: fix build issue with PHY LED control enabled Andrew Rybchenko
2017-11-27 19:59 ` Ferruh Yigit
2017-11-16 8:04 ` [dpdk-stable] [PATCH 41/53] net/sfc/base: fix diagnostics support build without Siena Andrew Rybchenko
2017-11-16 8:04 ` [dpdk-stable] [PATCH 42/53] net/sfc/base: fix probes in licensing support Andrew Rybchenko
2017-11-27 19:58 ` Ferruh Yigit
2017-11-28 10:17 ` Andrew Rybchenko
2017-11-28 21:38 ` Ferruh Yigit
2017-11-29 9:51 ` Andrew Rybchenko
2017-11-16 8:04 ` [dpdk-stable] [PATCH 43/53] net/sfc/base: fix warnings from VS2015 C compiler (C4310) Andrew Rybchenko
2017-11-16 8:04 ` [dpdk-stable] [PATCH 44/53] net/sfc/base: fix warnings from VS2015 C compiler (C4244) Andrew Rybchenko
2017-11-16 8:04 ` [dpdk-stable] [PATCH 45/53] net/sfc/base: fix warnings from VS2015 C compiler (C4245) Andrew Rybchenko
2017-11-16 8:04 ` [dpdk-stable] [PATCH 46/53] net/sfc/base: fix warnings from VS2015 C compiler (C4100) Andrew Rybchenko
2017-11-16 8:04 ` [dpdk-stable] [PATCH 47/53] net/sfc/base: fix warnings from VS2015 C compiler (C4189) Andrew Rybchenko
2017-11-16 8:04 ` [dpdk-stable] [PATCH 48/53] net/sfc/base: fix warnings from VS2015 C compiler (C4057) Andrew Rybchenko
2017-11-16 8:04 ` [dpdk-stable] [PATCH 49/53] net/sfc/base: fix warnings from VS2015 C compiler (C4214) Andrew Rybchenko
2017-11-16 8:04 ` [dpdk-stable] [PATCH 52/53] net/sfc/base: fix PreFAST static analysis warning (C6001) Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2e1de70-4acf-db91-527e-37c0e436c78b@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=amoreton@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).