From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "Wisam Jaddo" <wisamm@nvidia.com>, "Ori Kam" <orika@nvidia.com>,
"Aman Singh" <aman.deep.singh@intel.com>,
"Yuying Zhang" <yuying.zhang@intel.com>,
"Ajit Khaparde" <ajit.khaparde@broadcom.com>,
"Somnath Kotur" <somnath.kotur@broadcom.com>,
"Hemant Agrawal" <hemant.agrawal@nxp.com>,
"Sachin Saxena" <sachin.saxena@nxp.com>,
"Matan Azrad" <matan@nvidia.com>,
"Viacheslav Ovsiienko" <viacheslavo@nvidia.com>,
"Chaoyong He" <chaoyong.he@corigine.com>,
"Niklas Söderlund" <niklas.soderlund@corigine.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Olivier Matz" <olivier.matz@6wind.com>,
"David Marchand" <david.marchand@redhat.com>,
dev@dpdk.org
Subject: Re: [PATCH v6 4/8] ethdev: use GRE protocol struct for flow matching
Date: Fri, 3 Feb 2023 15:02:41 +0000 [thread overview]
Message-ID: <f365cc4e-5442-c00e-3437-5dbd1a8163e7@amd.com> (raw)
In-Reply-To: <837964623.0ifERbkFSE@thomas>
On 2/2/2023 5:16 PM, Thomas Monjalon wrote:
> 02/02/2023 13:44, Ferruh Yigit:
>> --- a/lib/net/rte_gre.h
>> +++ b/lib/net/rte_gre.h
>> @@ -28,6 +28,8 @@ extern "C" {
>> */
>> __extension__
>> struct rte_gre_hdr {
>> + union {
>> + struct {
>> #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
>> uint16_t res2:4; /**< Reserved */
>> uint16_t s:1; /**< Sequence Number Present bit */
>> @@ -45,6 +47,9 @@ struct rte_gre_hdr {
>> uint16_t res3:5; /**< Reserved */
>> uint16_t ver:3; /**< Version Number */
>> #endif
>> + };
>> + rte_be16_t c_rsvd0_ver;
>> + };
>> uint16_t proto; /**< Protocol Type */
>
> Why adding an unioned field c_rsvd0_ver?
>
>
Because existing usage in the drivers require to access these fields as
a single 16 bytes variable.
like mlx was using it as:
`X(SET_BE16, gre_c_ver, v->c_rsvd0_ver, rte_flow_item_gre) \`
When all usage switched to flow item specific fields to generic headers,
there needs a way to represent this in the generic header.
By adding 'c_rsvd0_ver' to generic header it becomes:
`X(SET_BE16, gre_c_ver, v->hdr.c_rsvd0_ver, rte_flow_item_gre) \`
Or another sample, previous version of code was updated as following:
`
- size = sizeof(((struct rte_flow_item_gre *)NULL)->c_rsvd0_ver);
+ size = sizeof(((struct rte_flow_item_gre *)NULL)->hdr.proto);
`
Because generic field to represent 'c_rsvd0_ver' is missing, 'hdr.proto'
was used, this was wrong.
Although the sizes of fields are same and functionally works, they are
different fields, this is worse than sizeof(uint16_t);
Another usage in testpmd:
`
[ITEM_GRE_C_RSVD0_VER] = {
.name = "c_rsvd0_ver",
@@ -4082,7 +4082,7 @@ static const struct token token_list[] = {
.next = NEXT(item_gre, NEXT_ENTRY(COMMON_UNSIGNED),
item_param),
.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_gre,
- c_rsvd0_ver)),
+ hdr.c_rsvd0_ver)),
`
But looking it again perhaps it can be named differently, because it is
not a reserved field in the generic header, though I am not sure what
can be a good variable name.
next prev parent reply other threads:[~2023-02-03 15:02 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 21:44 [PATCH 0/8] start cleanup of rte_flow_item_* Thomas Monjalon
2022-10-25 21:44 ` [PATCH 1/8] ethdev: use Ethernet protocol struct for flow matching Thomas Monjalon
2022-10-25 21:44 ` [PATCH 2/8] net: add smaller fields for VXLAN Thomas Monjalon
2022-10-25 21:44 ` [PATCH 3/8] ethdev: use VXLAN protocol struct for flow matching Thomas Monjalon
2022-10-25 21:44 ` [PATCH 4/8] ethdev: use GRE " Thomas Monjalon
2022-10-26 8:45 ` David Marchand
2023-01-20 17:21 ` Ferruh Yigit
2022-10-25 21:44 ` [PATCH 5/8] ethdev: use GTP " Thomas Monjalon
2022-10-25 21:44 ` [PATCH 6/8] ethdev: use ARP " Thomas Monjalon
2022-10-25 21:44 ` [PATCH 7/8] doc: fix description of L2TPV2 flow item Thomas Monjalon
2022-10-25 21:44 ` [PATCH 8/8] net: mark all big endian types Thomas Monjalon
2022-10-26 8:41 ` David Marchand
2023-01-20 17:18 ` [PATCH v2 0/8] start cleanup of rte_flow_item_* Ferruh Yigit
2023-01-20 17:18 ` [PATCH v2 1/8] ethdev: use Ethernet protocol struct for flow matching Ferruh Yigit
2023-01-20 17:18 ` [PATCH v2 2/8] net: add smaller fields for VXLAN Ferruh Yigit
2023-01-20 17:18 ` [PATCH v2 3/8] ethdev: use VXLAN protocol struct for flow matching Ferruh Yigit
2023-01-20 17:18 ` [PATCH v2 4/8] ethdev: use GRE " Ferruh Yigit
2023-01-20 17:18 ` [PATCH v2 5/8] ethdev: use GTP " Ferruh Yigit
2023-01-20 17:19 ` [PATCH v2 6/8] ethdev: use ARP " Ferruh Yigit
2023-01-20 17:19 ` [PATCH v2 7/8] doc: fix description of L2TPV2 flow item Ferruh Yigit
2023-01-20 17:19 ` [PATCH v2 8/8] net: mark all big endian types Ferruh Yigit
2023-01-22 10:52 ` [PATCH v2 0/8] start cleanup of rte_flow_item_* David Marchand
2023-01-24 9:07 ` Ferruh Yigit
2023-01-24 9:02 ` [PATCH v3 " Ferruh Yigit
2023-01-24 9:02 ` [PATCH v3 1/8] ethdev: use Ethernet protocol struct for flow matching Ferruh Yigit
2023-01-24 9:02 ` [PATCH v3 2/8] net: add smaller fields for VXLAN Ferruh Yigit
2023-01-24 9:02 ` [PATCH v3 3/8] ethdev: use VXLAN protocol struct for flow matching Ferruh Yigit
2023-01-24 9:02 ` [PATCH v3 4/8] ethdev: use GRE " Ferruh Yigit
2023-01-24 9:02 ` [PATCH v3 5/8] ethdev: use GTP " Ferruh Yigit
2023-01-24 9:02 ` [PATCH v3 6/8] ethdev: use ARP " Ferruh Yigit
2023-01-24 9:02 ` [PATCH v3 7/8] doc: fix description of L2TPV2 flow item Ferruh Yigit
2023-01-24 9:03 ` [PATCH v3 8/8] net: mark all big endian types Ferruh Yigit
2023-01-26 13:17 ` [PATCH v4 0/8] start cleanup of rte_flow_item_* Ferruh Yigit
2023-01-26 13:17 ` [PATCH v4 1/8] ethdev: use Ethernet protocol struct for flow matching Ferruh Yigit
2023-01-26 13:17 ` [PATCH v4 2/8] net: add smaller fields for VXLAN Ferruh Yigit
2023-01-26 13:17 ` [PATCH v4 3/8] ethdev: use VXLAN protocol struct for flow matching Ferruh Yigit
2023-01-26 13:17 ` [PATCH v4 4/8] ethdev: use GRE " Ferruh Yigit
2023-01-26 13:17 ` [PATCH v4 5/8] ethdev: use GTP " Ferruh Yigit
2023-01-26 13:17 ` [PATCH v4 6/8] ethdev: use ARP " Ferruh Yigit
2023-01-26 13:17 ` [PATCH v4 7/8] doc: fix description of L2TPV2 flow item Ferruh Yigit
2023-01-26 13:17 ` [PATCH v4 8/8] net: mark all big endian types Ferruh Yigit
2023-01-26 16:18 ` [PATCH v5 0/8] start cleanup of rte_flow_item_* Ferruh Yigit
2023-01-26 16:18 ` [PATCH v5 1/8] ethdev: use Ethernet protocol struct for flow matching Ferruh Yigit
2023-01-27 14:33 ` Niklas Söderlund
2023-02-01 17:34 ` Ori Kam
2023-02-02 9:51 ` Andrew Rybchenko
2023-01-26 16:18 ` [PATCH v5 2/8] net: add smaller fields for VXLAN Ferruh Yigit
2023-01-26 16:18 ` [PATCH v5 3/8] ethdev: use VXLAN protocol struct for flow matching Ferruh Yigit
2023-02-01 17:41 ` Ori Kam
2023-02-02 9:52 ` Andrew Rybchenko
2023-01-26 16:19 ` [PATCH v5 4/8] ethdev: use GRE " Ferruh Yigit
2023-01-27 14:34 ` Niklas Söderlund
2023-02-01 17:44 ` Ori Kam
2023-02-02 9:53 ` Andrew Rybchenko
2023-01-26 16:19 ` [PATCH v5 5/8] ethdev: use GTP " Ferruh Yigit
2023-02-02 9:54 ` Andrew Rybchenko
2023-01-26 16:19 ` [PATCH v5 6/8] ethdev: use ARP " Ferruh Yigit
2023-02-01 17:46 ` Ori Kam
2023-02-02 9:55 ` Andrew Rybchenko
2023-01-26 16:19 ` [PATCH v5 7/8] doc: fix description of L2TPV2 flow item Ferruh Yigit
2023-02-02 9:56 ` Andrew Rybchenko
2023-01-26 16:19 ` [PATCH v5 8/8] net: mark all big endian types Ferruh Yigit
2023-02-02 10:01 ` Andrew Rybchenko
2023-02-02 11:11 ` Ferruh Yigit
2023-02-02 12:44 ` [PATCH v6 0/8] start cleanup of rte_flow_item_* Ferruh Yigit
2023-02-02 12:44 ` [PATCH v6 1/8] ethdev: use Ethernet protocol struct for flow matching Ferruh Yigit
2023-02-02 12:44 ` [PATCH v6 2/8] net: add smaller fields for VXLAN Ferruh Yigit
2023-02-02 12:44 ` [PATCH v6 3/8] ethdev: use VXLAN protocol struct for flow matching Ferruh Yigit
2023-02-02 12:44 ` [PATCH v6 4/8] ethdev: use GRE " Ferruh Yigit
2023-02-02 17:16 ` Thomas Monjalon
2023-02-03 15:02 ` Ferruh Yigit [this message]
2023-02-03 15:12 ` Thomas Monjalon
2023-02-03 15:16 ` Ferruh Yigit
2023-02-02 12:44 ` [PATCH v6 5/8] ethdev: use GTP " Ferruh Yigit
2023-02-02 12:44 ` [PATCH v6 6/8] ethdev: use ARP " Ferruh Yigit
2023-02-02 12:44 ` [PATCH v6 7/8] doc: fix description of L2TPV2 flow item Ferruh Yigit
2023-02-02 12:45 ` [PATCH v6 8/8] net: mark all big endian types Ferruh Yigit
2023-02-02 17:20 ` Thomas Monjalon
2023-02-03 15:03 ` Ferruh Yigit
2023-02-03 16:48 ` [PATCH v7 0/7] start cleanup of rte_flow_item_* Ferruh Yigit
2023-02-03 16:48 ` [PATCH v7 1/7] ethdev: use Ethernet protocol struct for flow matching Ferruh Yigit
2023-02-03 16:48 ` [PATCH v7 2/7] net: add smaller fields for VXLAN Ferruh Yigit
2023-02-03 16:48 ` [PATCH v7 3/7] ethdev: use VXLAN protocol struct for flow matching Ferruh Yigit
2023-02-03 16:48 ` [PATCH v7 4/7] ethdev: use GTP " Ferruh Yigit
2023-02-03 16:48 ` [PATCH v7 5/7] ethdev: use ARP " Ferruh Yigit
2023-02-03 16:48 ` [PATCH v7 6/7] doc: fix description of L2TPV2 flow item Ferruh Yigit
2023-02-03 16:48 ` [PATCH v7 7/7] net: mark all big endian types Ferruh Yigit
2023-02-06 2:35 ` [PATCH v7 0/7] start cleanup of rte_flow_item_* fengchengwen
2023-02-07 14:58 ` Thomas Monjalon
2023-02-07 16:33 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f365cc4e-5442-c00e-3437-5dbd1a8163e7@amd.com \
--to=ferruh.yigit@amd.com \
--cc=ajit.khaparde@broadcom.com \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=chaoyong.he@corigine.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=matan@nvidia.com \
--cc=niklas.soderlund@corigine.com \
--cc=olivier.matz@6wind.com \
--cc=orika@nvidia.com \
--cc=sachin.saxena@nxp.com \
--cc=somnath.kotur@broadcom.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=wisamm@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).