DPDK patches and discussions
 help / color / mirror / Atom feed
From: fengchengwen <fengchengwen@huawei.com>
To: Robin Jarry <rjarry@redhat.com>, <dev@dpdk.org>
Cc: "Bruce Richardson" <bruce.richardson@intel.com>,
	"Jerin Jacob" <jerinj@marvell.com>,
	"Kevin Laatz" <kevin.laatz@intel.com>,
	"Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
	"Mattias Rönnblom" <hofors@lysator.liu.se>,
	"Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [RFC PATCH 3/4] testpmd: add show lcores command
Date: Thu, 24 Nov 2022 08:54:35 +0800	[thread overview]
Message-ID: <f3db21d1-4fe8-116a-8a51-66ab0bdeabbc@huawei.com> (raw)
In-Reply-To: <20221123101931.1688238-4-rjarry@redhat.com>

Hi Robin,

On 2022/11/23 18:19, Robin Jarry wrote:
> Add a simple command that calls rte_lcore_dump().
> 
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
> ---
>  app/test-pmd/cmdline.c | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index b32dc8bfd445..d290938ffb4e 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -7151,6 +7151,36 @@ static cmdline_parse_inst_t cmd_showfwdall = {
>  	},
>  };
>  
> +/* show lcores */
> +struct lcores_result {
> +	cmdline_fixed_string_t show;
> +	cmdline_fixed_string_t lcores;
> +};
> +
> +static cmdline_parse_token_string_t cmd_lcores_action =
> +	TOKEN_STRING_INITIALIZER(struct lcores_result, show, "show");
> +static cmdline_parse_token_string_t cmd_lcores_lcores =
> +	TOKEN_STRING_INITIALIZER(struct lcores_result, lcores, "lcores");
> +
> +static void
> +cmd_showlcores_parsed(__rte_unused void *parsed_result,
> +		      __rte_unused struct cmdline *cl,
> +		      __rte_unused void *data)
> +{
> +	rte_lcore_dump(stdout);
> +}
> +
> +static cmdline_parse_inst_t cmd_showlcores = {
> +	.f = cmd_showlcores_parsed,
> +	.data = NULL,
> +	.help_str = "show lcores",
> +	.tokens = {
> +		(void *)&cmd_lcores_action,
> +		(void *)&cmd_lcores_lcores,
> +		NULL,
> +	},
> +};

There are many dump_xxx cmd, suggest the commands as dump_lcores:
testpmd> dump_
 dump_physmem [Mul-choice STRING]: Dump status
 dump_memzone [Mul-choice STRING]: Dump status
 dump_socket_mem [Mul-choice STRING]: Dump status
 dump_struct_sizes [Mul-choice STRING]: Dump status
 dump_ring [Mul-choice STRING]: Dump status
 dump_mempool [Mul-choice STRING]: Dump status
 dump_devargs [Mul-choice STRING]: Dump status
 dump_log_types [Mul-choice STRING]: Dump status
 dump_ring [Mul-choice STRING]: dump_ring|dump_mempool <name>: Dump one ring/mempool
 dump_mempool [Mul-choice STRING]: dump_ring|dump_mempool <name>: Dump one ring/mempool

> +
>  /* *** READ A RING DESCRIPTOR OF A PORT RX/TX QUEUE *** */
>  struct cmd_read_rxd_txd_result {
>  	cmdline_fixed_string_t read;
> @@ -12637,6 +12667,7 @@ static cmdline_parse_ctx_t builtin_ctx[] = {
>  	(cmdline_parse_inst_t *)&cmd_showdevice,
>  	(cmdline_parse_inst_t *)&cmd_showcfg,
>  	(cmdline_parse_inst_t *)&cmd_showfwdall,
> +	(cmdline_parse_inst_t *)&cmd_showlcores,
>  	(cmdline_parse_inst_t *)&cmd_start,
>  	(cmdline_parse_inst_t *)&cmd_start_tx_first,
>  	(cmdline_parse_inst_t *)&cmd_start_tx_first_n,
> 

  reply	other threads:[~2022-11-24  0:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23 10:19 [RFC PATCH 0/4] lcore telemetry improvements Robin Jarry
2022-11-23 10:19 ` [RFC PATCH 1/4] eal: add lcore info in telemetry Robin Jarry
2022-11-23 10:19 ` [RFC PATCH 2/4] eal: allow applications to report their cpu utilization Robin Jarry
2022-11-23 11:52   ` Morten Brørup
2022-11-23 13:29     ` Robin Jarry
2022-11-23 16:38   ` Stephen Hemminger
2022-11-23 10:19 ` [RFC PATCH 3/4] testpmd: add show lcores command Robin Jarry
2022-11-24  0:54   ` fengchengwen [this message]
2022-11-23 10:19 ` [RFC PATCH 4/4] testpmd: report lcore usage Robin Jarry
2022-11-23 10:44 ` [RFC PATCH 0/4] lcore telemetry improvements Robin Jarry
2022-11-23 10:26 Robin Jarry
2022-11-23 10:26 ` [RFC PATCH 3/4] testpmd: add show lcores command Robin Jarry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3db21d1-4fe8-116a-8a51-66ab0bdeabbc@huawei.com \
    --to=fengchengwen@huawei.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=hofors@lysator.liu.se \
    --cc=jerinj@marvell.com \
    --cc=kevin.laatz@intel.com \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=mb@smartsharesystems.com \
    --cc=rjarry@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).