From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jasvinder Singh <jasvinder.singh@intel.com>, dev@dpdk.org
Cc: cristian.dumitrescu@intel.com, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/softnic: enable flow classification function
Date: Thu, 7 Dec 2017 13:02:38 -0800 [thread overview]
Message-ID: <f42ee212-c7f1-a5b9-c70c-e555da346a38@intel.com> (raw)
In-Reply-To: <20171130200843.98621-2-jasvinder.singh@intel.com>
On 11/30/2017 12:08 PM, Jasvinder Singh wrote:
> Enables flow classification on softnic rx path so that proceding
> functions of the packet processing pipeline such as metering and
> policing could be implemented.
>
> Example: Create "soft" port for "hard" port "0000:02:00.1",
> enable the Flow Classification (FC) feature with default
> settings:
> --vdev 'net_softnic0,hard_name=0000:02:00.1,soft_fc=on'
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
<...>
> +#define PMD_PARAM_SOFT_FC "soft_fc"
> +#define PMD_PARAM_SOFT_FC_NB_RULES "soft_fc_nb_rules"
> +#define PMD_PARAM_SOFT_FC_FLOW_KEY_SIZE "soft_fc_flow_key_size"
> +#define PMD_PARAM_SOFT_FC_FLOW_KEY_OFFSET "soft_fc_flow_key_offset"
> +#define PMD_PARAM_SOFT_FC_FLOW_KEY_MASK "soft_fc_flow_key_mask"
> +
> #define PMD_PARAM_HARD_NAME "hard_name"
> #define PMD_PARAM_HARD_TX_QUEUE_ID "hard_tx_queue_id"
I wouldn't mention if you won't be already sending a new version but can you
please align them :)
<...>
> @@ -60,7 +60,9 @@ _LDLIBS-y += -L$(RTE_SDK_BIN)/lib
> #
> _LDLIBS-$(CONFIG_RTE_LIBRTE_FLOW_CLASSIFY) += -lrte_flow_classify
> _LDLIBS-$(CONFIG_RTE_LIBRTE_PIPELINE) += -lrte_pipeline
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE) += --whole-archive
> _LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE) += -lrte_table
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE) += --no-whole-archive
I think it is better to move rte_table between whole-archive flags, but I
vaguely remember Thomas preferred this in the past, so adding him for comment.
next prev parent reply other threads:[~2017-12-07 21:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 20:08 [dpdk-dev] [PATCH 0/2] net/softnic: add flow classification support Jasvinder Singh
2017-11-30 20:08 ` [dpdk-dev] [PATCH 1/2] net/softnic: enable flow classification function Jasvinder Singh
2017-12-07 21:02 ` Ferruh Yigit [this message]
2017-12-07 22:16 ` Thomas Monjalon
2017-12-08 9:53 ` Singh, Jasvinder
2017-11-30 20:08 ` [dpdk-dev] [PATCH 2/2] net/softnic: add flow classification ops Jasvinder Singh
2017-12-07 21:02 ` [dpdk-dev] [PATCH 0/2] net/softnic: add flow classification support Ferruh Yigit
2017-12-08 9:50 ` Singh, Jasvinder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f42ee212-c7f1-a5b9-c70c-e555da346a38@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).