From: Ferruh Yigit <ferruh.yigit@intel.com>
To: mk@semihalf.com, mw@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com
Cc: Daria Kolistratova <daria.kolistratova@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/1] ena: fix SIGFPE with 0 rx queues
Date: Tue, 26 Jun 2018 17:53:37 +0100 [thread overview]
Message-ID: <f49a0e00-2263-5004-49a9-ef9f8bc4d9c8@intel.com> (raw)
In-Reply-To: <20180626110734.25181-1-daria.kolistratova@intel.com>
On 6/26/2018 6:38 PM, Ferruh Yigit wrote:
> From: Daria Kolistratova <daria.kolistratova@intel.com>
I re-send the Daria's patch, somehow it didn't appeared in mail list and patchwork.
>
> When the number of rx queues is 0
> (what can be when application does not receive)
> failed with SIGFPE. It happens when the application
> is also requesting ETH_MQ_RX_RSS_FLAG in the
> rte_dev->data->dev_conf.rxmode.mq_mode.
> Fixed adding zero rx queues check.
>
> Signed-off-by: Daria Kolistratova <daria.kolistratova@intel.com>
> ---
> drivers/net/ena/ena_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
> index 9ae73e331..3249b9d92 100644
> --- a/drivers/net/ena/ena_ethdev.c
> +++ b/drivers/net/ena/ena_ethdev.c
> @@ -1052,7 +1052,7 @@ static int ena_start(struct rte_eth_dev *dev)
> return rc;
>
> if (adapter->rte_dev->data->dev_conf.rxmode.mq_mode &
> - ETH_MQ_RX_RSS_FLAG) {
> + ETH_MQ_RX_RSS_FLAG && adapter->rte_dev->data->nb_rx_queues > 0) {
> rc = ena_rss_init_default(adapter);
> if (rc)
> return rc;
>
next prev parent reply other threads:[~2018-06-26 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180625134046.12448-1-daria.kolistratova@intel.com>
2018-06-26 7:29 ` [dpdk-dev] [PATCH " Michał Krawczyk
2018-06-26 17:38 ` [dpdk-dev] [PATCH v2 " Ferruh Yigit
2018-06-26 11:15 ` Michał Krawczyk
2018-06-26 16:53 ` Ferruh Yigit [this message]
2018-06-27 8:36 ` Michał Krawczyk
2018-06-27 13:22 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f49a0e00-2263-5004-49a9-ef9f8bc4d9c8@intel.com \
--to=ferruh.yigit@intel.com \
--cc=daria.kolistratova@intel.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=gtzalik@amazon.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).