From: Maryam Tahhan <mtahhan@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: ferruh.yigit@amd.com, stephen@networkplumber.org,
lihuisong@huawei.com, fengchengwen@huawei.com,
liuyonglong@huawei.com, shibin.koikkara.reeny@intel.com,
ciara.loftus@intel.com, dev@dpdk.org
Subject: Re: [v6] net/af_xdp: enable uds_path instead of use_cni
Date: Thu, 21 Dec 2023 11:46:24 +0000 [thread overview]
Message-ID: <f5174066-5292-4647-8249-49e26f552ed8@redhat.com> (raw)
In-Reply-To: <CAJFAV8zfx7ZOff0deGQP3_v6NS+Z61uHNY-V+QyJVQ8-Wz9cyA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1446 bytes --]
On 21/12/2023 11:36, David Marchand wrote:
> Hello,
>
> On Fri, Dec 15, 2023 at 4:40 PM Maryam Tahhan<mtahhan@redhat.com> wrote:
>> With the original 'use_cni' implementation, (using a
>> hardcoded socket rather than a configurable one),
>> if a DPDK pod is requesting multiple net devices
>> and these devices are from different pools, then
>> the container attempts to mount all the netdev UDSes
>> in the pod as /tmp/afxdp.sock. Which means that at best
>> only 1 netdev will handshake correctly with the AF_XDP
>> DP. This patch addresses this by making the socket
>> parameter configurable using a new vdev param called
>> 'uds_path' and removing the previous 'use_cni' param.
>> This patch also fixes incorrect references to the
>> AF_XDP DP as CNI and updates the documentation with a
>> working example. This change has been tested with the
> If there are fixes mixed in, please separate them in dedicated patches
> so we can backport them to LTS releases.
Thanks for the Feedback David, I don't quite understand the ask here, is
to to have a separate patch for documentation to fixes? As previous
feedback in the mailing list was to keep the documentation changes with
the fix.
There is one fix in this patchset (for for broken socket behaviour). The
rest of the changes were fixing up all the documentation. So do I need
to create a patchset with multiple patches, one for the c code and
separate ones for the documentation?
[-- Attachment #2: Type: text/html, Size: 2111 bytes --]
next prev parent reply other threads:[~2023-12-21 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 15:39 Maryam Tahhan
2023-12-21 10:44 ` Koikkara Reeny, Shibin
2023-12-21 11:36 ` David Marchand
2023-12-21 11:46 ` Maryam Tahhan [this message]
2023-12-21 11:57 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5174066-5292-4647-8249-49e26f552ed8@redhat.com \
--to=mtahhan@redhat.com \
--cc=ciara.loftus@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=shibin.koikkara.reeny@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).