From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/nfp: fix mbufs releasing when stop or close
Date: Tue, 24 Apr 2018 15:10:44 +0100 [thread overview]
Message-ID: <f5753147-a237-a435-7edf-93280092be1e@intel.com> (raw)
In-Reply-To: <1524482638-22281-1-git-send-email-alejandro.lucero@netronome.com>
On 4/23/2018 12:23 PM, Alejandro Lucero wrote:
> PMDs have the responsabilty of releasing mbufs sent through xmit burst
> function. NFP PMD attaches those sent mbufs to the TX ring structure,
> and it is at the next time a specific ring descriptor is going to be
> used when the previous linked mbuf, already transmitted at that point,
> is released. Those mbufs belonging to a chained mbuf got its own link
> to a ring descriptor, and they are released independently of the mbuf
> head of that chain.
>
> The problem is how those mbufs are released when the PMD is stopped or
> closed. Instead of releasing those mbufs as the xmit functions does,
> this is independently of being in a mbuf chain, the code calls
> rte_pktmbuf_free which will release not just the mbuf head in that
> chain but all the chained mbufs. The loop will try to release those
> mbufs which have already been released again when chained mbufs exist.
>
> This patch fixes the problem using rte_pktmbuf_free_seg instead.
>
> Fixes: b812daadad0d ("nfp: add Rx and Tx")
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-04-24 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 11:23 Alejandro Lucero
2018-04-24 14:10 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5753147-a237-a435-7edf-93280092be1e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).