From: Chas Williams <3chas3@gmail.com>
To: kkanas@marvell.com, dev@dpdk.org, david.marchand@redhat.com,
Chas Williams <chas3@att.com>
Cc: danielx.t.mrzyglod@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] net/bonding: fix selection logic
Date: Thu, 10 Oct 2019 09:30:17 -0400 [thread overview]
Message-ID: <f5805b6b-b12b-63e1-e5e8-35862f45f503@gmail.com> (raw)
In-Reply-To: <20191010082705.22109-1-kkanas@marvell.com>
On 10/10/19 4:27 AM, kkanas@marvell.com wrote:
> From: Krzysztof Kanas <kkanas@marvell.com>
>
> Arrays agg_count and agg_bandwidth should be indexed by slave_id not by
> aggregator port_id.
>
> Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes")
> Cc: danielx.t.mrzyglod@intel.com
>
> Signed-off-by: Krzysztof Kanas <kkanas@marvell.com>
> ---
> drivers/net/bonding/rte_eth_bond_8023ad.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
> index 7d8da2b318f5..5b489b070b09 100644
> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
> @@ -673,9 +673,8 @@ selection_logic(struct bond_dev_private *internals, uint16_t slave_id)
> uint64_t agg_bandwidth[RTE_MAX_ETHPORTS] = {0};
> uint64_t agg_count[RTE_MAX_ETHPORTS] = {0};
> uint16_t default_slave = 0;
> - uint16_t mode_count_id;
> - uint16_t mode_band_id;
> struct rte_eth_link link_info;
> + uint16_t agg_new_idx = 0;
> int ret;
>
> slaves = internals->active_slaves;
> @@ -696,8 +695,8 @@ selection_logic(struct bond_dev_private *internals, uint16_t slave_id)
> slaves[i], rte_strerror(-ret));
> continue;
> }
> - agg_count[agg->aggregator_port_id] += 1;
> - agg_bandwidth[agg->aggregator_port_id] += link_info.link_speed;
> + agg_count[i] += 1;
> + agg_bandwidth[i] += link_info.link_speed;
>
> /* Actors system ID is not checked since all slave device have the same
> * ID (MAC address). */
> @@ -717,13 +716,13 @@ selection_logic(struct bond_dev_private *internals, uint16_t slave_id)
> }
>
> switch (internals->mode4.agg_selection) {
> + agg_new_idx = max_index(agg_count, slaves_count);
> + new_agg_id = slaves[agg_new_idx];
> case AGG_COUNT:
> - mode_count_id = max_index(agg_count, slaves_count);
> - new_agg_id = mode_count_id;
This change doesn't look right. Did you really want to do this, put the
code outside of the case statement?
> break;
> case AGG_BANDWIDTH:
> - mode_band_id = max_index(agg_bandwidth, slaves_count);
> - new_agg_id = mode_band_id;
> + agg_new_idx = max_index(agg_bandwidth, slaves_count);
> + new_agg_id = slaves[agg_new_idx];
> break;
> case AGG_STABLE:
> if (default_slave == slaves_count)
>
next prev parent reply other threads:[~2019-10-10 13:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 14:44 [dpdk-dev] [PATCH 1/2] net/bonding: fix stack overflow in " kkanas
2019-08-05 14:44 ` [dpdk-dev] [PATCH 2/2] net/bonding: fix " kkanas
2019-10-08 14:34 ` Yigit, Ferruh
2019-10-10 8:27 ` [dpdk-dev] [PATCH v2] " kkanas
2019-10-10 13:30 ` Chas Williams [this message]
2019-10-11 6:34 ` [dpdk-dev] [PATCH v3] " kkanas
2019-10-11 15:38 ` Chas Williams
2019-11-13 8:22 ` [dpdk-dev] [PATCH v4] " kkanas
2019-11-15 15:56 ` Ferruh Yigit
2019-08-05 15:09 ` [dpdk-dev] [PATCH 1/2] net/bonding: fix stack overflow in " David Marchand
2019-08-07 7:41 ` [dpdk-dev] [EXT] " Krzysztof Kanas
2019-10-08 14:33 ` [dpdk-dev] " Yigit, Ferruh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5805b6b-b12b-63e1-e5e8-35862f45f503@gmail.com \
--to=3chas3@gmail.com \
--cc=chas3@att.com \
--cc=danielx.t.mrzyglod@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=kkanas@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).