From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>, <stable@dpdk.org>,
<dev@dpdk.org>, Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] vfio: do not use memcmp() to compare PCI address
Date: Fri, 31 Mar 2017 19:18:21 +0300 [thread overview]
Message-ID: <f5827858-a5fc-7ec2-a8be-b989afedca21@solarflare.com> (raw)
In-Reply-To: <a544a4f4-aed5-0517-9f84-4bbbe81e14f3@intel.com>
On 03/31/2017 07:09 PM, Sergio Gonzalez Monroy wrote:
> On 31/03/2017 16:56, Andrew Rybchenko wrote:
>> PCI address structure has padding which may have garbage.
>>
>> Fixes: 2f4adfad0a69 ("vfio: add multiprocess support")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>> It is a real bug which I've hit during multi-process debugging.
>>
>> lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
>> b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
>> index 5f478c5..7d8b9fb 100644
>> --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
>> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
>> @@ -355,7 +355,8 @@ pci_vfio_map_resource(struct rte_pci_device *dev)
>> } else {
>> /* if we're in a secondary process, just find our tailq
>> entry */
>> TAILQ_FOREACH(vfio_res, vfio_res_list, next) {
>> - if (memcmp(&vfio_res->pci_addr, &dev->addr,
>> sizeof(dev->addr)))
>> + if (rte_eal_compare_pci_addr(&vfio_res->pci_addr,
>> + &dev->addr))
>> continue;
>> break;
>> }
>
> Different commit, same patch :)
> https://urldefense.proofpoint.com/v2/url?u=http-3A__dpdk.org_dev_patchwork_patch_21828_&d=DQICaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=flTOx6Av679My7o_iScb5sOlLD68bpUyE2RUtfW3SWQ&m=uvsF8SJaLsRNp3l01Ji5iD4EB1hkHVPOX_dFKqTu_mU&s=HYxvqVvNsbEzQgMJmwQuH6G7vqOkyg7vJ1PrzsxKr5c&e=
True, sorry, lost your patch from my view.
I'm not sure which state should be set on my patch in the patchwork.
Thomas, please, resolve it properly.
Thanks,
Andrew.
next prev parent reply other threads:[~2017-03-31 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 15:56 [dpdk-stable] " Andrew Rybchenko
2017-03-31 16:09 ` [dpdk-stable] [dpdk-dev] " Sergio Gonzalez Monroy
2017-03-31 16:18 ` Andrew Rybchenko [this message]
2017-03-31 16:24 ` Sergio Gonzalez Monroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5827858-a5fc-7ec2-a8be-b989afedca21@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=stable@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).