From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Abhishek Maheshwari <abhishek.maheshwari@intel.com>,
xiao.w.wang@intel.com
Cc: dev@dpdk.org, stable@dpdk.org, chenbo.xia@intel.com,
purna.chandra.mandal@intel.com
Subject: Re: [PATCH v4] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices
Date: Thu, 19 Jan 2023 15:09:23 +0100 [thread overview]
Message-ID: <f6aa813a-cc07-e71e-1649-62c8183b9380@redhat.com> (raw)
In-Reply-To: <20221215034818.2145612-1-abhishek.maheshwari@intel.com>
Hi Abhishek,
On 12/15/22 04:48, Abhishek Maheshwari wrote:
> Amending the match table for vdpa/ifcvf driver to work with virtio-blk
> devices that have default subsystem IDs.
>
> Cc: stable@dpdk.org
Is that really a fix? If so, you need to add the Fixes tag so that LTS
maintainers know on which LTS it applies.
Other than that:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
If you provide me with the faulty commit, I can add it when applying.
Thanks,
Maxime
Thanks,
Maxime
>
> Signed-off-by: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
>
> ---
> v3:
> * Removing match with ANY_IDs
> * Adding support for only default subsystem IDs
>
> v2:
> * commit message update
> ---
> drivers/vdpa/ifc/base/ifcvf.h | 1 +
> drivers/vdpa/ifc/ifcvf_vdpa.c | 7 +++++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h
> index 3726da7a33..04c81c8196 100644
> --- a/drivers/vdpa/ifc/base/ifcvf.h
> +++ b/drivers/vdpa/ifc/base/ifcvf.h
> @@ -20,6 +20,7 @@
> #define IFCVF_SUBSYS_DEVICE_ID 0x001A
> #define IFCVF_SUBSYS_NET_DEVICE_ID 0x0001
> #define IFCVF_SUBSYS_BLK_DEVICE_ID 0x0002
> +#define IFCVF_SUBSYS_DEFAULT_DEVICE_ID 0x0000
>
> #define IFCVF_MAX_QUEUES 32
>
> diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
> index 49d68ad1b1..edc6db545d 100644
> --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
> +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
> @@ -1849,6 +1849,13 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
> .subsystem_device_id = IFCVF_SUBSYS_BLK_DEVICE_ID,
> },
>
> + { .class_id = RTE_CLASS_ANY_ID,
> + .vendor_id = IFCVF_VENDOR_ID,
> + .device_id = IFCVF_BLK_MODERN_DEVICE_ID,
> + .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
> + .subsystem_device_id = IFCVF_SUBSYS_DEFAULT_DEVICE_ID,
> + }, /* virtio-blk devices with default subsystem IDs */
> +
> { .vendor_id = 0, /* sentinel */
> },
> };
next prev parent reply other threads:[~2023-01-19 14:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 12:50 [PATCH] vdpa/ifc: Match ANY subsystem IDs for modern virtio devices Abhishek Maheshwari
2022-12-06 12:55 ` [PATCH v2] " Abhishek Maheshwari
2022-12-08 13:08 ` Wang, Xiao W
2022-12-09 2:37 ` Pei, Andy
2022-12-15 3:42 ` [PATCH v3] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices Abhishek Maheshwari
2022-12-15 3:48 ` [PATCH v4] " Abhishek Maheshwari
2022-12-16 1:58 ` Pei, Andy
2023-01-19 14:09 ` Maxime Coquelin [this message]
2023-02-03 14:57 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6aa813a-cc07-e71e-1649-62c8183b9380@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=abhishek.maheshwari@intel.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=purna.chandra.mandal@intel.com \
--cc=stable@dpdk.org \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).