From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Rasesh Mody <rasesh.mody@cavium.com>,
Harish Patil <harish.patil@cavium.com>,
Shahed Shaikh <shahed.shaikh@cavium.com>,
Yong Wang <yongwang@vmware.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool
Date: Mon, 24 Sep 2018 15:43:59 +0100 [thread overview]
Message-ID: <f713c4df-7286-ae9d-ddd0-d1aefd76ccc0@intel.com> (raw)
In-Reply-To: <5551506.CmDVCAXTxv@xps>
On 9/21/2018 3:49 PM, Thomas Monjalon wrote:
> 21/09/2018 15:47, Ferruh Yigit:
>> On 9/20/2018 1:18 AM, Thomas Monjalon wrote:
>>> When trying to include stdbool.h in DPDK base headers, there are a lot
>>> of conflicts with drivers which redefine bool/true/false
>>> in their compatibility layer.
>>>
>>> It is fixed by including stdbool.h in these drivers.
>>> Some errors with usage of bool type are also fixed in some drivers.
>>>
>>> Note: the driver qede has a surprising mix of bool and int:
>>> (~p_iov->b_pre_fp_hsi & ETH_HSI_VER_MINOR)
>>> where the first variable is boolean and the version is a number.
>>> It is replaced by
>>> !p_iov->b_pre_fp_hsi
>>>
>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>>> ---
>>> drivers/net/cxgbe/cxgbe_compat.h | 2 +-
>>> drivers/net/e1000/base/e1000_osdep.h | 5 +----
>>> drivers/net/fm10k/base/fm10k_osdep.h | 8 +-------
>>> drivers/net/fm10k/fm10k_ethdev.c | 4 ++--
>>> drivers/net/ixgbe/base/ixgbe_osdep.h | 6 +-----
>>> drivers/net/ixgbe/ixgbe_ethdev.c | 16 +++++++++-------
>>> drivers/net/ixgbe/ixgbe_rxtx.c | 2 +-
>>> drivers/net/qede/base/bcm_osal.h | 6 ++----
>>> drivers/net/qede/base/ecore_vf.c | 3 +--
>>> drivers/net/qede/qede_ethdev.c | 2 +-
>>> drivers/net/vmxnet3/base/vmxnet3_osdep.h | 3 ++-
>>> 11 files changed, 22 insertions(+), 35 deletions(-)
>>
>> <...>
>>
>>> @@ -35,6 +35,7 @@
>>> #ifndef _E1000_OSDEP_H_
>>> #define _E1000_OSDEP_H_
>>>
>>> +#include <stdbool.h>
>>> #include <stdint.h>
>>> #include <stdio.h>
>>> #include <stdarg.h>
>>> @@ -87,7 +88,6 @@ typedef int64_t s64;
>>> typedef int32_t s32;
>>> typedef int16_t s16;
>>> typedef int8_t s8;
>>> -typedef int bool;
>>>
>>> #define __le16 u16
>>> #define __le32 u32
>>> @@ -192,7 +192,4 @@ static inline uint16_t e1000_read_addr16(volatile void *addr)
>>> #define ETH_ADDR_LEN 6
>>> #endif
>>>
>>> -#define false FALSE
>>> -#define true TRUE
>>> -
>>
>> It is too much hassle to update Intel base driver code.
>
> It is not really base driver code.
> It was agreed that *_osdep.h can be modified:
> http://git.dpdk.org/dpdk/tree/drivers/net/ixgbe/base/README#n56
Right.
>
>> What would happen if not
>> include stdbool and keep define for base code updates? Will it break build for
>> applications?
>
> The problem is not applications, but using stdbool in DPDK headers.
I see.
next prev parent reply other threads:[~2018-09-24 14:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 0:18 Thomas Monjalon
2018-09-20 17:48 ` Shaikh, Shahed
2018-09-21 13:47 ` Ferruh Yigit
2018-09-21 14:49 ` Thomas Monjalon
2018-09-24 14:43 ` Ferruh Yigit [this message]
2018-09-24 15:06 ` Ferruh Yigit
2018-09-24 16:59 ` Thomas Monjalon
2018-09-25 8:03 ` Ferruh Yigit
2018-09-25 9:04 ` Thomas Monjalon
2018-10-03 14:11 ` Ferruh Yigit
2018-10-03 19:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f713c4df-7286-ae9d-ddd0-d1aefd76ccc0@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=harish.patil@cavium.com \
--cc=konstantin.ananyev@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rasesh.mody@cavium.com \
--cc=shahed.shaikh@cavium.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).