From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Eads, Gage" <gage.eads@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/pcap: set queue started and stopped
Date: Wed, 18 Jul 2018 15:25:06 +0100 [thread overview]
Message-ID: <f7224488-47bc-a253-c7f8-8bf9a78cbb2a@intel.com> (raw)
In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E446EDBE7@FMSMSX108.amr.corp.intel.com>
On 7/18/2018 3:17 PM, Eads, Gage wrote:
>
>
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Wednesday, July 18, 2018 4:14 AM
>> To: Eads, Gage <gage.eads@intel.com>; dev@dpdk.org
>> Subject: Re: [PATCH] net/pcap: set queue started and stopped
>>
>> On 7/9/2018 9:21 PM, Gage Eads wrote:
>>> Set the rx and tx queue state appropriately when the queues or device
>>> are started or stopped.
>>
>> Is there a specific reason to enable these dev_ops, if so can you please
>> document in commit log?
>
> Yes, the purpose of the patch is to enable the rte_eth_dev_{rx, tx}_queue_{start, stop} functions for the PCAP PMD. I'll update the message in v2.
I guess that part is clear :) I was asking if there is a higher level reason to
enable queue start/stop on these PMDs?
Is there some specific usecase not working for you when these are not enabled?
>
>>
>>>
>>> Signed-off-by: Gage Eads <gage.eads@intel.com>
>>> ---
>>> drivers/net/pcap/rte_eth_pcap.c | 42
>>> +++++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 42 insertions(+)
>>>
>>> diff --git a/drivers/net/pcap/rte_eth_pcap.c
>>> b/drivers/net/pcap/rte_eth_pcap.c index 6bd4a7d79..21e466bcd 100644
>>> --- a/drivers/net/pcap/rte_eth_pcap.c
>>> +++ b/drivers/net/pcap/rte_eth_pcap.c
>>> @@ -430,6 +430,10 @@ eth_dev_start(struct rte_eth_dev *dev)
>>> return -1;
>>> rx->pcap = tx->pcap;
>>> }
>>> +
>>> + dev->data->tx_queue_state[0] =
>> RTE_ETH_QUEUE_STATE_STARTED;
>>> + dev->data->rx_queue_state[0] =
>> RTE_ETH_QUEUE_STATE_STARTED;
>>
>> pcap also supports multiple queue, instead of hardcoding the queue 0 it can be
>> possible to iterate through dev->data->nb_rx_queues, dev->data-
>>> nb_tx_queues.
>>
>> And I think it is not good to set this in "internals->single_iface" condition, it is
>> better to do these assignments just above "status_up" after all queues
>> initialized.
>>
>>> +
>>> goto status_up;
>>> }
>>>
>>> @@ -490,6 +494,8 @@ eth_dev_stop(struct rte_eth_dev *dev)
>>> pcap_close(tx->pcap);
>>> tx->pcap = NULL;
>>> rx->pcap = NULL;
>>> + dev->data->tx_queue_state[0] =
>> RTE_ETH_QUEUE_STATE_STOPPED;
>>> + dev->data->rx_queue_state[0] =
>> RTE_ETH_QUEUE_STATE_STOPPED;
>>
>> same here, just above "status_down" is better place and by using
>> dev->data->nb_[r/t]x_queues
>
> Agreed, I will move the started and stopped assignments as you suggested.
>
next prev parent reply other threads:[~2018-07-18 14:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 20:21 Gage Eads
2018-07-18 9:13 ` Ferruh Yigit
2018-07-18 14:17 ` Eads, Gage
2018-07-18 14:25 ` Ferruh Yigit [this message]
2018-07-18 16:04 ` Eads, Gage
2018-07-18 16:06 ` Ferruh Yigit
2018-07-18 16:30 ` [dpdk-dev] [PATCH v2] " Gage Eads
2018-07-19 9:32 ` Ferruh Yigit
2018-07-19 9:56 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7224488-47bc-a253-c7f8-8bf9a78cbb2a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).