From: "lihuisong (C)" <lihuisong@huawei.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
David Marchand <david.marchand@redhat.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>,
Joshua Washington <joshwash@google.com>
Subject: Re: [PATCH] app/testpmd: fix forwarding stats for Tx dropped
Date: Wed, 1 Feb 2023 09:14:27 +0800 [thread overview]
Message-ID: <f7298ca7-03a5-ec1e-1ee1-b10630b6f9c4@huawei.com> (raw)
In-Reply-To: <20230131115603.640254-1-ferruh.yigit@amd.com>
Maybe many PMDs do not support oerrors statistics, which cause this
problem isn't found.
LGTM
Acked-by: Huisong Li <lihuisong@huawei.com>
在 2023/1/31 19:56, Ferruh Yigit 写道:
> There is an inconsistency at displaying Tx dropped value for per port
> forwarding stats and accumulated forwarding stats.
>
> While displaying per port TX-dropped value, it only takes
> 'ports_stats[pt_id].tx_dropped' into account,
> but for accumulated TX-dropped results it takes both
> 'ports_stats[pt_id].tx_dropped' & 'stats.oerrors' into account.
>
> To fix, make both per port and accumulated stats display 'tx_dropped'
> and 'stats.oerrors' (ports_stats[pt_id].tx_dropped + stats.oerrors).
>
> Fixes: 53324971a14e ("app/testpmd: display/clear forwarding stats on demand")
> Cc: stable@dpdk.org
>
> Reported-by: Joshua Washington <joshwash@google.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
> ---
>
> Cc: david.marchand@redhat.com
>
> Mail list reference:
> https://inbox.dpdk.org/dev/a440ab60-9624-f21e-396a-239bdf2aa1a1@amd.com/
> ---
> app/test-pmd/testpmd.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 60eb9579ded1..6f4749b8af0c 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2057,6 +2057,8 @@ fwd_stats_display(void)
> fwd_cycles += fs->core_cycles;
> }
> for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++) {
> + uint64_t tx_dropped = 0;
> +
> pt_id = fwd_ports_ids[i];
> port = &ports[pt_id];
>
> @@ -2078,8 +2080,9 @@ fwd_stats_display(void)
> total_recv += stats.ipackets;
> total_xmit += stats.opackets;
> total_rx_dropped += stats.imissed;
> - total_tx_dropped += ports_stats[pt_id].tx_dropped;
> - total_tx_dropped += stats.oerrors;
> + tx_dropped += ports_stats[pt_id].tx_dropped;
> + tx_dropped += stats.oerrors;
> + total_tx_dropped += tx_dropped;
> total_rx_nombuf += stats.rx_nombuf;
>
> printf("\n %s Forward statistics for port %-2d %s\n",
> @@ -2106,8 +2109,8 @@ fwd_stats_display(void)
>
> printf(" TX-packets: %-14"PRIu64" TX-dropped: %-14"PRIu64
> "TX-total: %-"PRIu64"\n",
> - stats.opackets, ports_stats[pt_id].tx_dropped,
> - stats.opackets + ports_stats[pt_id].tx_dropped);
> + stats.opackets, tx_dropped,
> + stats.opackets + tx_dropped);
>
> if (record_burst_stats) {
> if (ports_stats[pt_id].rx_stream)
next prev parent reply other threads:[~2023-02-01 1:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 11:56 Ferruh Yigit
2023-02-01 1:14 ` lihuisong (C) [this message]
2023-02-07 10:10 ` Singh, Aman Deep
2023-02-08 2:07 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7298ca7-03a5-ec1e-1ee1-b10630b6f9c4@huawei.com \
--to=lihuisong@huawei.com \
--cc=aman.deep.singh@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=ferruh.yigit@intel.com \
--cc=joshwash@google.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).