From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Harish Patil <harish.patil@qlogic.com>, dev@dpdk.org
Cc: Dept-EngDPDKDev@qlogic.com
Subject: Re: [dpdk-dev] [PATCH 6/7] net/qede: fix maximum VF count to 0
Date: Thu, 8 Dec 2016 16:45:21 +0000 [thread overview]
Message-ID: <f7ccf786-4f58-5e1e-3cd2-28725bb4e8b5@intel.com> (raw)
In-Reply-To: <1480733039-13046-6-git-send-email-harish.patil@qlogic.com>
On 12/3/2016 2:43 AM, Harish Patil wrote:
> Set max_vfs to 0 since it is relevant only to SR-IOV PF
> which is not supported yet.
>
> Fixes: 2ea6f76a ("qede: add core driver")
>
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
Can you please update patch title to indicate what has been fixed
instead of what has been done in the patch.
btw, while checking feature list, I have seen qede_vf supports SR-IOV,
is that correct?
> ---
> drivers/net/qede/qede_ethdev.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
> index ee8fb43..10abb8b 100644
> --- a/drivers/net/qede/qede_ethdev.c
> +++ b/drivers/net/qede/qede_ethdev.c
> @@ -976,10 +976,7 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev)
> dev_info->max_rx_queues = (uint16_t)QEDE_MAX_RSS_CNT(qdev);
> dev_info->max_tx_queues = dev_info->max_rx_queues;
> dev_info->max_mac_addrs = qdev->dev_info.num_mac_addrs;
> - if (IS_VF(edev))
> - dev_info->max_vfs = 0;
> - else
> - dev_info->max_vfs = (uint16_t)NUM_OF_VFS(&qdev->edev);
> + dev_info->max_vfs = 0;
> dev_info->reta_size = ECORE_RSS_IND_TABLE_SIZE;
> dev_info->hash_key_size = ECORE_RSS_KEY_SIZE * sizeof(uint32_t);
> dev_info->flow_type_rss_offloads = (uint64_t)QEDE_RSS_OFFLOAD_ALL;
>
next prev parent reply other threads:[~2016-12-08 16:45 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 2:43 [dpdk-dev] [PATCH 1/7] net/qede: reduce noise in debug logs Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 2/7] net/qede: refactor filtering code Harish Patil
2016-12-08 16:45 ` Ferruh Yigit
2016-12-12 17:36 ` Harish Patil
2016-12-12 17:53 ` Ferruh Yigit
2016-12-20 23:12 ` Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 3/7] net/qede: add slowpath support for VXLAN tunneling Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 4/7] net/qede: add fastpath " Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 5/7] net/qede: fix RSS related issue Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 6/7] net/qede: fix maximum VF count to 0 Harish Patil
2016-12-08 16:45 ` Ferruh Yigit [this message]
2016-12-12 17:47 ` Harish Patil
2016-12-12 18:13 ` Ferruh Yigit
2016-12-19 13:38 ` Thomas Monjalon
2016-12-20 23:15 ` Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 7/7] net/qede: restrict maximum queues for PF/VF Harish Patil
2016-12-08 16:45 ` Ferruh Yigit
2016-12-12 19:29 ` Harish Patil
2016-12-12 20:10 ` Ferruh Yigit
2016-12-20 23:16 ` Harish Patil
2016-12-08 16:44 ` [dpdk-dev] [PATCH 1/7] net/qede: reduce noise in debug logs Ferruh Yigit
2016-12-12 17:15 ` Harish Patil
2016-12-12 17:50 ` Ferruh Yigit
2016-12-20 22:02 ` Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 " Harish Patil
2016-12-23 15:14 ` Ferruh Yigit
2016-12-23 15:25 ` Ferruh Yigit
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 2/7] net/qede: fix filtering code Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 3/7] net/qede: add slowpath support for VXLAN tunneling Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 4/7] net/qede: add fastpath " Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 5/7] net/qede: fix RSS related issue Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 6/7] net/qede: fix reporting of SR-IOV PF driver as disabled Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 7/7] net/qede: restrict maximum queues for PF/VF Harish Patil
2016-12-08 16:48 ` [dpdk-dev] [PATCH 1/7] net/qede: reduce noise in debug logs Ferruh Yigit
2016-12-20 23:29 ` Mody, Rasesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ccf786-4f58-5e1e-3cd2-28725bb4e8b5@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Dept-EngDPDKDev@qlogic.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).