From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dpdklab <dpdklab@iol.unh.edu>,
Thomas Monjalon <thomas@monjalon.net>,
Gaetan Rivet <gaetanr@nvidia.com>, dev <dev@dpdk.org>,
"Xueming\(Steven\) Li" <xuemingl@nvidia.com>,
Asaf Penso <asafp@nvidia.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
Gaetan Rivet <grive@u256.net>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Dodji Seketeli <dodji@redhat.com>,
ci@dpdk.org, Owen Hilyard <ohilyard@iol.unh.edu>
Subject: Re: [dpdk-ci] [dpdk-dev] [PATCH v5 1/5] devargs: unify scratch buffer storage
Date: Fri, 16 Apr 2021 08:32:17 -0400 [thread overview]
Message-ID: <f7t1rba76lq.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <CAJFAV8y8mV9sTu2q6UaXgFSknN9g-9_cVe5BT2vEsGwP2fApsQ@mail.gmail.com> (David Marchand's message of "Fri, 16 Apr 2021 09:00:13 +0200")
David Marchand <david.marchand@redhat.com> writes:
> On Tue, Apr 13, 2021 at 5:15 AM Xueming Li <xuemingl@nvidia.com> wrote:
>> diff --git a/lib/librte_eal/include/rte_devargs.h b/lib/librte_eal/include/rte_devargs.h
>> index 296f19324f..134b44a887 100644
>> --- a/lib/librte_eal/include/rte_devargs.h
>> +++ b/lib/librte_eal/include/rte_devargs.h
>> @@ -60,16 +60,16 @@ struct rte_devargs {
>> /** Name of the device. */
>> char name[RTE_DEV_NAME_MAX_LEN];
>> RTE_STD_C11
>> - union {
>> - /** Arguments string as given by user or "" for no argument. */
>> - char *args;
>> + union { /**< driver-related part of device string. */
>> + const char *args; /**< legacy name. */
>> const char *drv_str;
>> };
>> struct rte_bus *bus; /**< bus handle. */
>> struct rte_class *cls; /**< class handle. */
>> const char *bus_str; /**< bus-related part of device string. */
>> const char *cls_str; /**< class-related part of device string. */
>> - const char *data; /**< Device string storage. */
>> + char *data;
>> + /**< Raw string including bus, class and driver arguments. */
>> };
>>
>> /**
>
> - Flagging this patch for info and its impact on UNH jobs.
>
> This change is fine, but older libabigail versions could not deal with
> such changes (anonymous union, changes of const fields).
> This results in an ABI check failure in the UNH x86 job on Ubuntu
> 18.04 (and for some people not using recent libabigail).
> I can see the ARM job passes fine, so I suppose it is using a more
> recent libabigail (running Ubuntu 20.04 maybe?).
>
> We either need to disable this x86 job or update its libabigail
> package (maybe aligning with what we have for public CI which is
> libabigail 1.8 manually compiled).
>
>
> - For the longer term, what do you think of using/extending the .ci/
> scripts for use by UNH jobs?
I think it would be great if we had some of the scripts shared as a
common resource. That would also help us to look at fixes / changes
when needed.
next prev parent reply other threads:[~2021-04-16 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1608304614-13908-2-git-send-email-xuemingl@nvidia.com>
[not found] ` <1618283653-16510-1-git-send-email-xuemingl@nvidia.com>
[not found] ` <1618283653-16510-2-git-send-email-xuemingl@nvidia.com>
2021-04-16 7:00 ` David Marchand
2021-04-16 12:32 ` Aaron Conole [this message]
2021-04-16 12:43 ` [dpdk-ci] [dpdklab] " Lincoln Lavoie
2021-04-16 12:58 ` Thomas Monjalon
2021-04-16 13:14 ` Lincoln Lavoie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7t1rba76lq.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=asafp@nvidia.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=ci@dpdk.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dodji@redhat.com \
--cc=dpdklab@iol.unh.edu \
--cc=ferruh.yigit@intel.com \
--cc=gaetanr@nvidia.com \
--cc=grive@u256.net \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=ohilyard@iol.unh.edu \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).