From: Aaron Conole <aconole@redhat.com>
To: Ruifeng Wang <ruifeng.wang@arm.com>
Cc: maicolgabriel@hotmail.com, bruce.richardson@intel.com,
konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com,
yipeng1.wang@intel.com, sameh.gobriel@intel.com, dev@dpdk.org,
david.marchand@redhat.com, anatoly.burakov@intel.com,
gavin.hu@arm.com, honnappa.nagarahalli@arm.com,
juraj.linkes@pantheon.tech, nd@arm.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v3 1/4] test: enable tests to run in no-huge mode
Date: Tue, 17 Mar 2020 08:49:20 -0400 [thread overview]
Message-ID: <f7t1rpr6t9r.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <20200313081614.195335-2-ruifeng.wang@arm.com> (Ruifeng Wang's message of "Fri, 13 Mar 2020 16:16:11 +0800")
Ruifeng Wang <ruifeng.wang@arm.com> writes:
> When running with '--no-huge' flag, tests failed with messages as:
> ACL context creation with invalid NUMA should have failed!
> fbk hash creation should have failed
> test_table_pipeline: Check pipeline invalid params failed.
>
> These cases test against invalid socket ID as input parameter, and
> expect error return. But function calls return success because
> invalid sock ID is overwritten to SOCKET_ID_ANY when in no-huge mode.
>
> The tests against invalid socket ID are skipped in no-huge mode.
>
> Fixes: 5640171c528a ("malloc: fix external heap allocation in no-huge mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
Acked-by: Aaron Conole <aconole@redhat.com>
> app/test/test_acl.c | 22 ++++++++++++----------
> app/test/test_hash.c | 7 +++++--
> app/test/test_table_pipeline.c | 12 +++++++-----
> 3 files changed, 24 insertions(+), 17 deletions(-)
>
> diff --git a/app/test/test_acl.c b/app/test/test_acl.c
> index 501de35da..316bf4d06 100644
> --- a/app/test/test_acl.c
> +++ b/app/test/test_acl.c
> @@ -1397,16 +1397,18 @@ test_invalid_parameters(void)
> } else
> rte_acl_free(acx);
>
> - /* invalid NUMA node */
> - memcpy(¶m, &acl_param, sizeof(param));
> - param.socket_id = RTE_MAX_NUMA_NODES + 1;
> -
> - acx = rte_acl_create(¶m);
> - if (acx != NULL) {
> - printf("Line %i: ACL context creation with invalid NUMA "
> - "should have failed!\n", __LINE__);
> - rte_acl_free(acx);
> - return -1;
> + if (rte_eal_has_hugepages()) {
> + /* invalid NUMA node */
> + memcpy(¶m, &acl_param, sizeof(param));
> + param.socket_id = RTE_MAX_NUMA_NODES + 1;
> +
> + acx = rte_acl_create(¶m);
> + if (acx != NULL) {
> + printf("Line %i: ACL context creation with invalid "
> + "NUMA should have failed!\n", __LINE__);
> + rte_acl_free(acx);
> + return -1;
> + }
> }
>
> /* NULL name */
> diff --git a/app/test/test_hash.c b/app/test/test_hash.c
> index fbd5725c6..ab978ea68 100644
> --- a/app/test/test_hash.c
> +++ b/app/test/test_hash.c
> @@ -1136,8 +1136,11 @@ fbk_hash_unit_test(void)
> handle = rte_fbk_hash_create(&invalid_params_7);
> RETURN_IF_ERROR_FBK(handle != NULL, "fbk hash creation should have failed");
>
> - handle = rte_fbk_hash_create(&invalid_params_8);
> - RETURN_IF_ERROR_FBK(handle != NULL, "fbk hash creation should have failed");
> + if (rte_eal_has_hugepages()) {
> + handle = rte_fbk_hash_create(&invalid_params_8);
> + RETURN_IF_ERROR_FBK(handle != NULL,
> + "fbk hash creation should have failed");
> + }
>
> handle = rte_fbk_hash_create(&invalid_params_same_name_1);
> RETURN_IF_ERROR_FBK(handle == NULL, "fbk hash creation should have succeeded");
> diff --git a/app/test/test_table_pipeline.c b/app/test/test_table_pipeline.c
> index 441338ac0..bc412c308 100644
> --- a/app/test/test_table_pipeline.c
> +++ b/app/test/test_table_pipeline.c
> @@ -190,11 +190,13 @@ check_pipeline_invalid_params(void)
> goto fail;
> }
>
> - p = rte_pipeline_create(&pipeline_params_3);
> - if (p != NULL) {
> - RTE_LOG(INFO, PIPELINE, "%s: Configure pipeline with invalid "
> - "socket\n", __func__);
> - goto fail;
> + if (rte_eal_has_hugepages()) {
> + p = rte_pipeline_create(&pipeline_params_3);
> + if (p != NULL) {
> + RTE_LOG(INFO, PIPELINE, "%s: Configure pipeline with "
> + "invalid socket\n", __func__);
> + goto fail;
> + }
> }
>
> /* Check pipeline consistency */
next prev parent reply other threads:[~2020-03-17 12:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200225073236.135581-1-ruifeng.wang@arm.com>
[not found] ` <20200313081614.195335-1-ruifeng.wang@arm.com>
2020-03-13 8:16 ` Ruifeng Wang
2020-03-17 12:49 ` Aaron Conole [this message]
2020-03-17 19:15 ` Wang, Yipeng1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7t1rpr6t9r.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=juraj.linkes@pantheon.tech \
--cc=konstantin.ananyev@intel.com \
--cc=maicolgabriel@hotmail.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=sameh.gobriel@intel.com \
--cc=stable@dpdk.org \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).