From: Aaron Conole <aconole@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, david.marchand@redhat.com,
Michael Santana <maicolgabriel@hotmail.com>,
Lincoln Lavoie <lylavoie@iol.unh.edu>,
Owen Hilyard <ohilyard@iol.unh.edu>
Subject: Re: [PATCH] ci: remove outdated default reference tag for ABI
Date: Tue, 08 Feb 2022 10:08:53 -0500 [thread overview]
Message-ID: <f7t8rul8kfu.fsf@redhat.com> (raw)
In-Reply-To: <20220208134715.796609-1-thomas@monjalon.net> (Thomas Monjalon's message of "Tue, 8 Feb 2022 14:47:15 +0100")
Thomas Monjalon <thomas@monjalon.net> writes:
> The variable REF_GIT_TAG is set in the CI configuration
> like .travis.yml or .github/workflows/build.yml.
> The default value is outdated and probably unused.
> It is removed completely to avoid forgetting an update in future.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
I think the default was there for labs that run the build script
manually. Maybe there are no such users, though. I believe the lab has
its own script for doing such ABI checks (but can't remember off the top
of my head).
CC'd Lincoln and Owen just to confirm.
Assuming the UNH/other lab doesn't use this feature of the linux build
script,
Acked-by: Aaron Conole <aconole@redhat.com>
next prev parent reply other threads:[~2022-02-08 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 13:47 Thomas Monjalon
2022-02-08 15:08 ` Aaron Conole [this message]
2022-02-08 22:03 ` Brandon Lo
2022-02-09 13:37 ` Thomas Monjalon
2022-02-09 14:04 ` David Marchand
2022-03-01 9:56 ` [PATCH v2] ci: remove outdated default versions for ABI check Thomas Monjalon
2022-03-01 10:07 ` David Marchand
2022-03-06 9:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7t8rul8kfu.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=lylavoie@iol.unh.edu \
--cc=maicolgabriel@hotmail.com \
--cc=ohilyard@iol.unh.edu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).