From: Aaron Conole <aconole@redhat.com>
To: Moti Haimovsky <motih@mellanox.com>
Cc: thomas@monjalon.net, jasvinder.singh@intel.com, dev@dpdk.org,
stable@dpdk.org, Bala Sankaran <bsankara@redhat.com>,
Reshma Pattan <reshma.pattan@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] app/testpmd: removed softnic CLI modifications
Date: Wed, 25 Jul 2018 16:27:16 -0400 [thread overview]
Message-ID: <f7th8kn12or.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <1532532609-16216-1-git-send-email-motih@mellanox.com> (Moti Haimovsky's message of "Wed, 25 Jul 2018 18:30:09 +0300")
Moti Haimovsky <motih@mellanox.com> writes:
> This patch reverts the testpmd CLI prompt routine modifications done
> in order to support softnic.
> The reason of doing so is due to testpmd abnormal exit observed on
> several setups caused by the softnic modifications to this routine,
> for example: When running testpmd with tap interface
> (/app/testpmd
> -n 4 --vdev=net_tap0,iface=tap0,remote=eth1 -- --burst=64
> --mbcache=512 -i --nb-cores=7 --rxq=2 --txq=2 --txd=512
> --rxd=512 --port-topology=chained --forward-mode=rxonly)
> testpmd crashes seconds after presenting its prompt with the following
> error:
> testpmd> PANIC in prompt():
> CLI poll error (-1)
>
> Thread 1 "testpmd" received signal SIGABRT, Aborted.
> 0x00007ffff668e0d0 in raise () from /lib64/libc.so.6
> (gdb) bt
> #0 0x00007ffff668e0d0 in raise () from /lib64/libc.so.6
> #1 0x00007ffff668f6b1 in abort () from /lib64/libc.so.6
> #2 0x0000000000468027 in __rte_panic ()
> #3 0x00000000004876ed in prompt ()
> #4 0x000000000046dffc in main ()
>
> When running testpmd with bare-metal device
> (app/testpmd -n 4 --socket-mem=1024,1024 -w 04:00.0 --
> --burst=64 --mbcache=512 -i --nb-cores=7
> --rxq=64 --txq=4 --txd=16 --rxd=16)
> and pressing CTRL+D right after testpmd prompt is presented then
> the program crashes while presenting the same messages as above.
>
> Needless to say that this behavior is not observed when using the
> previous CLI prompt routine.
>
> Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> ---
Thanks for the fix - I was just writing to explain that I observe this
on master but see that folks are busy fixing it up.
I've applied this patch, and no longer see the panic.
Acked-by: Aaron Conole <aconole@redhat.com>
prev parent reply other threads:[~2018-07-25 20:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 14:40 [dpdk-stable] [PATCH v2] " Moti Haimovsky
2018-07-25 14:42 ` Thomas Monjalon
2018-07-25 14:59 ` Singh, Jasvinder
2018-07-25 15:30 ` [dpdk-stable] [PATCH v3] " Moti Haimovsky
2018-07-25 16:15 ` [dpdk-stable] [dpdk-dev] " Dumitrescu, Cristian
2018-07-25 20:27 ` Aaron Conole [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7th8kn12or.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=bsankara@redhat.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=motih@mellanox.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).