From: Aaron Conole <aconole@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: remove redundant error output
Date: Wed, 21 Aug 2019 09:04:00 -0400 [thread overview]
Message-ID: <f7timqqisan.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <20190820233330.27474-1-stephen@networkplumber.org> (Stephen Hemminger's message of "Tue, 20 Aug 2019 16:33:30 -0700")
Stephen Hemminger <stephen@networkplumber.org> writes:
> The function rte_eal_init_alert ends up printing the same message
> twice. Once via RTE_LOG and once to stderr. Remove the fprintf
> to stderr since it is redundant.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
This was originally added at your suggestion:
http://mails.dpdk.org/archives/dev/2017-January/056431.html
Because sometimes we have these alerts before logging is up (so the
RTE_LOG(...) won't show up, I gather).
Is it possible to have an either/or?
> lib/librte_eal/linux/eal/eal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c
> index 946222ccdb7a..076fb3cbde5f 100644
> --- a/lib/librte_eal/linux/eal/eal.c
> +++ b/lib/librte_eal/linux/eal/eal.c
> @@ -949,7 +949,6 @@ static int rte_eal_vfio_setup(void)
>
> static void rte_eal_init_alert(const char *msg)
> {
> - fprintf(stderr, "EAL: FATAL: %s\n", msg);
> RTE_LOG(ERR, EAL, "%s\n", msg);
> }
next prev parent reply other threads:[~2019-08-21 13:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 23:33 Stephen Hemminger
2019-08-21 13:04 ` Aaron Conole [this message]
2019-09-19 13:31 ` [dpdk-dev] [PATCH v2] eal: don't call RTE_LOG before init Stephen Hemminger
2019-10-16 7:42 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7timqqisan.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).