From: Aaron Conole <aconole@redhat.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: dev <dev@dpdk.org>, Eelco Chaudron <echaudro@redhat.com>,
Pablo Cascon <pablo.cascon@redhat.com>,
Subject: Re: [dpdk-dev] [RFC 0/2] nfp driver fixes
Date: Fri, 13 Apr 2018 09:23:04 -0400 [thread overview]
Message-ID: <f7tin8vz1dz.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <CAD+H9916Rjwup_RVkBiLP6yM60n-T+XhdKHYA_q_4pw94XW9Cw@mail.gmail.com> (Alejandro Lucero's message of "Fri, 13 Apr 2018 09:26:55 +0200")
Alejandro Lucero <alejandro.lucero@netronome.com> writes:
> Hi Aaron,
>
> Thanks for this patches.
>
> I'm afraid these are not applicable for current NFP driver after commit
Okay.
> "net/nfp: add NFP CPP support"
>
> which has been accepted in dpdk-net-next.
I think nfp_acquire_process_lock() can be modified as I did in 2/2, but
I noticed that there's some reliance on various sysfs files (and I think
you point this out in your response to 2/2 as well) and that may be
problematic for us with ovs2.8+. I'll do some more digging.
Thanks Alejandro!
> However, those could be valid for stable versions. I have comments on both patches.
Cool. As I noted, I haven't tested them yet, but once I get time to
test them I will pull in any feedback and resubmit. I guess if I do,
they should really just be for stable fixes? Not sure how that would
work.
> On Fri, Apr 13, 2018 at 12:22 AM, Aaron Conole <aconole@redhat.com> wrote:
>
> Two fixes, one which is fairly obvious (1/2), the other which may
> allow support of non-root users. These patches are only compile tested
> which is why they are submitted as RFC. After a proper test, will
> resubmit them as PATCH (with any suggested / recommended changes).
>
> Aaron Conole (2):
> nfp: unlink the appropriate lock file
> nfp: allow for non-root user
>
> drivers/net/nfp/nfp_nfpu.c | 25 +++++++++++++++++++++----
> 1 file changed, 21 insertions(+), 4 deletions(-)
>
> --
> 2.14.3
next prev parent reply other threads:[~2018-04-13 13:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 22:22 Aaron Conole
2018-04-12 22:22 ` [dpdk-dev] [RFC 1/2] nfp: unlink the appropriate lock file Aaron Conole
2018-04-13 7:31 ` Alejandro Lucero
2018-04-13 13:24 ` Aaron Conole
2018-04-12 22:22 ` [dpdk-dev] [RFC 2/2] nfp: allow for non-root user Aaron Conole
2018-04-13 7:37 ` Alejandro Lucero
2018-04-13 13:31 ` Aaron Conole
2018-04-13 15:31 ` Alejandro Lucero
2018-04-17 15:44 ` Alejandro Lucero
2018-04-17 15:54 ` Alejandro Lucero
2018-04-17 19:19 ` Aaron Conole
2018-04-18 10:53 ` Alejandro Lucero
2018-04-18 12:32 ` Aaron Conole
2018-04-19 6:05 ` Alejandro Lucero
2018-04-20 14:12 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-04-20 14:56 ` Aaron Conole
2018-04-17 15:54 ` [dpdk-dev] " Thomas Monjalon
2018-04-17 16:24 ` Alejandro Lucero
2018-04-17 19:06 ` Thomas Monjalon
2018-04-13 7:26 ` [dpdk-dev] [RFC 0/2] nfp driver fixes Alejandro Lucero
2018-04-13 13:23 ` Aaron Conole [this message]
2018-04-13 15:36 ` Alejandro Lucero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tin8vz1dz.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=echaudro@redhat.com \
--cc=pablo.cascon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).