From: Aaron Conole <aconole@redhat.com>
To: "Burakov\, Anatoly" <anatoly.burakov@intel.com>
Cc: "Chaitanya Babu\, TalluriX" <tallurix.chaitanya.babu@intel.com>,
"dev\@dpdk.org" <dev@dpdk.org>, "Pattan\,
Reshma" <reshma.pattan@intel.com>, "Parthasarathy\,
JananeeX M" <jananeex.m.parthasarathy@intel.com>
Subject: Re: [dpdk-dev] [PATCH 3/3] app/test: add unit tests for eal vfio
Date: Thu, 22 Aug 2019 10:40:36 -0400 [thread overview]
Message-ID: <f7tlfvli7q3.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <d9ddbd53-a6e3-054d-9e46-ce9a1d8bca0e@intel.com> (Anatoly Burakov's message of "Thu, 22 Aug 2019 11:57:41 +0100")
"Burakov, Anatoly" <anatoly.burakov@intel.com> writes:
> On 22-Aug-19 8:18 AM, Chaitanya Babu, TalluriX wrote:
>> Hi Aaron,
>>
>>> -----Original Message-----
>>> From: Aaron Conole [mailto:aconole@redhat.com]
>>> Sent: Wednesday, August 21, 2019 9:15 PM
>>> To: Chaitanya Babu, TalluriX <tallurix.chaitanya.babu@intel.com>
>>> Cc: dev@dpdk.org; Pattan, Reshma <reshma.pattan@intel.com>;
>>> Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>;
>>> Burakov, Anatoly <anatoly.burakov@intel.com>
>>> Subject: Re: [dpdk-dev] [PATCH 3/3] app/test: add unit tests for eal vfio
>>>
>>> Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com> writes:
>>>
>>>> Unit test cases are added for eal vfio library.
>>>> eal_vfio_autotest added to meson build file.
>>>>
>>>> Signed-off-by: Chaitanya Babu Talluri
>>>> <tallurix.chaitanya.babu@intel.com>
>>>> ---
>>>
>>> Thanks for adding unit tests for the vfio library.
>>>
>>> In this case, there seems to be some failures - can you help determine the
>>> cause:
>>>
>> As per log we observed
>> "EAL: VFIO support not initialized"
>>
>> Can you Please check if device is binded or not with vfio-pci.
>> If device is not binded we might get this error (EAL: VFIO support not initialized).
>>
>> We have binded the device and observed the tests are running fine as expected.
>>
>>> https://travis-ci.com/ovsrobot/dpdk/jobs/227066776
>>
>
> The test should be skipped if VFIO if VFIO is not initialized.
+1 - not every developer will have that set up for their systems. And
for those developers building drive-by patches, we shouldn't make the
unit tests unusable.
> I think
> we have an API for that, although it is not meant to be used by
> application code.
next prev parent reply other threads:[~2019-08-22 14:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 13:02 [dpdk-dev] [PATCH 0/3] add unit tests for eal vfio library Chaitanya Babu Talluri
2019-08-21 13:02 ` [dpdk-dev] [PATCH 1/3] lib/eal: fix vfio unmap that fails unexpectedly Chaitanya Babu Talluri
2019-08-21 13:20 ` Burakov, Anatoly
2019-08-21 13:02 ` [dpdk-dev] [PATCH 2/3] lib/eal: fix vfio unmap that succeeds unexpectedly Chaitanya Babu Talluri
2019-08-21 13:24 ` Burakov, Anatoly
2019-08-21 13:02 ` [dpdk-dev] [PATCH 3/3] app/test: add unit tests for eal vfio Chaitanya Babu Talluri
2019-08-21 15:44 ` Aaron Conole
2019-08-22 7:18 ` Chaitanya Babu, TalluriX
2019-08-22 10:57 ` Burakov, Anatoly
2019-08-22 14:40 ` Aaron Conole [this message]
2019-08-22 11:53 ` [dpdk-dev] [PATCH v2 0/3] add unit tests for eal vfio library Chaitanya Babu Talluri
2019-08-27 11:57 ` [dpdk-dev] [PATCH v3 0/4] " Chaitanya Babu Talluri
2019-09-04 12:04 ` [dpdk-dev] [PATCH v4 " Chaitanya Babu Talluri
2019-09-23 15:56 ` Burakov, Anatoly
2023-06-14 19:37 ` Stephen Hemminger
2019-09-04 12:04 ` [dpdk-dev] [PATCH v4 1/4] lib/eal: fix vfio unmap that fails unexpectedly Chaitanya Babu Talluri
2019-09-04 12:04 ` [dpdk-dev] [PATCH v4 2/4] lib/eal: fix vfio unmap that succeeds unexpectedly Chaitanya Babu Talluri
2019-09-04 12:04 ` [dpdk-dev] [PATCH v4 3/4] lib/eal: add API to check iommu type is set Chaitanya Babu Talluri
2019-09-04 12:04 ` [dpdk-dev] [PATCH v4 4/4] app/test: add unit tests for eal vfio Chaitanya Babu Talluri
2019-08-27 11:57 ` [dpdk-dev] [PATCH v3 1/4] lib/eal: fix vfio unmap that fails unexpectedly Chaitanya Babu Talluri
2019-08-27 11:57 ` [dpdk-dev] [PATCH v3 2/4] lib/eal: fix vfio unmap that succeeds unexpectedly Chaitanya Babu Talluri
2019-08-27 11:57 ` [dpdk-dev] [PATCH v3 3/4] lib/eal: add API to check iommu type is set Chaitanya Babu Talluri
2019-08-27 11:57 ` [dpdk-dev] [PATCH v3 4/4] app/test: add unit tests for eal vfio Chaitanya Babu Talluri
2019-08-22 11:53 ` [dpdk-dev] [PATCH v2 1/3] lib/eal: fix vfio unmap that fails unexpectedly Chaitanya Babu Talluri
2019-08-22 11:53 ` [dpdk-dev] [PATCH v2 2/3] lib/eal: fix vfio unmap that succeeds unexpectedly Chaitanya Babu Talluri
2019-08-22 11:53 ` [dpdk-dev] [PATCH v2 3/3] app/test: add unit tests for eal vfio Chaitanya Babu Talluri
2019-08-22 12:15 ` Burakov, Anatoly
2019-08-23 7:57 ` Chaitanya Babu, TalluriX
2019-08-23 9:12 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tlfvli7q3.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=reshma.pattan@intel.com \
--cc=tallurix.chaitanya.babu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).