From: Aaron Conole <aconole@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>, Abdullah Sevincer <abdullah.sevincer@intel.com>
Subject: Re: [PATCH] event/dlb2: remove unnecessary timer call
Date: Wed, 13 Dec 2023 16:31:47 -0500 [thread overview]
Message-ID: <f7tmsudokl8.fsf@redhat.com> (raw)
In-Reply-To: <ZXnlj6BXwH6Qm3Ho@bricha3-MOBL.ger.corp.intel.com> (Bruce Richardson's message of "Wed, 13 Dec 2023 17:10:39 +0000")
Bruce Richardson <bruce.richardson@intel.com> writes:
> On Wed, Dec 13, 2023 at 11:50:46AM -0500, Aaron Conole wrote:
>> Bruce Richardson <bruce.richardson@intel.com> writes:
>>
>> > We only need to consult the timer value when the driver waits for a
>> > timeout, so skip making the call to get the current timer/TSC value if
>> > the timeout is zero, as no wait will ever be done.
>> >
>> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>> > ---
>>
>> Had a bad config value - retrying again.
>>
>> (Apologies to Bruce for the noise on this patch)
>>
> No problem!
> We are going for the record for best-checked patch in DPDK history, right? :-)
Absolutely! If we're removing a call, best be safe.
prev parent reply other threads:[~2023-12-13 21:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 11:48 Bruce Richardson
2023-12-13 15:22 ` Sevincer, Abdullah
2023-12-14 6:58 ` Jerin Jacob
2023-12-13 15:41 ` Aaron Conole
2023-12-13 16:50 ` Aaron Conole
2023-12-13 17:10 ` Bruce Richardson
2023-12-13 21:31 ` Aaron Conole [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tmsudokl8.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=abdullah.sevincer@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).