From: Aaron Conole <aconole@redhat.com>
To: Min Zhou <zhoumin@loongson.cn>
Cc: ci@dpdk.org, msantana@redhat.com, dmarchan@redhat.com,
thomas@monjalon.net, probb@iol.unh.edu, dceara@redhat.com
Subject: Re: [PATCH v1] tools: fix parsing message-id in the headers of email
Date: Thu, 07 Dec 2023 14:07:20 -0500 [thread overview]
Message-ID: <f7to7f13k7r.fsf@redhat.com> (raw)
In-Reply-To: <20231204025246.14779-1-zhoumin@loongson.cn> (Min Zhou's message of "Mon, 4 Dec 2023 02:52:46 +0000")
Min Zhou <zhoumin@loongson.cn> writes:
> Some email has the message-id header named "Message-id", like this:
> https://patches.dpdk.org/project/dpdk/patch/20230930010024.34377-1-rdna@apple.com/.
> So add the parsing for this kind of email.
>
> Signed-off-by: Min Zhou <zhoumin@loongson.cn>
> ---
Hi Min,
I wonder - we will keep having this issue of these header fields being
incorrectly matched based on case issues.
Maybe we should make getheader have the ability to ignore case, or pass
something like Message-[iI][dD] as the header argument.
WDYT?
> tools/parse-email.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/parse-email.sh b/tools/parse-email.sh
> index 9cb9583..fbe038a 100755
> --- a/tools/parse-email.sh
> +++ b/tools/parse-email.sh
> @@ -35,6 +35,7 @@ subject=$(getheader Subject "$1")
> from=$(getheader From "$1")
> msgid=$(getheader Message-Id "$1")
> [ -n "$msgid" ] || msgid=$(getheader Message-ID "$1")
> +[ -n "$msgid" ] || msgid=$(getheader Message-id "$1")
> pwid=$(getheader X-Patchwork-Id "$1")
> listid=$(getheader List-Id "$1")
> reply=$(getheader In-Reply-To "$1")
next prev parent reply other threads:[~2023-12-07 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 2:52 Min Zhou
2023-12-07 19:07 ` Aaron Conole [this message]
2023-12-08 3:53 ` zhoumin
2023-12-13 12:53 ` Aaron Conole
2023-12-14 2:36 ` zhoumin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7to7f13k7r.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=ci@dpdk.org \
--cc=dceara@redhat.com \
--cc=dmarchan@redhat.com \
--cc=msantana@redhat.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
--cc=zhoumin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).