From: Aaron Conole <aconole@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, tredaelli@redhat.com
Subject: Re: [dpdk-dev] [PATCH 1/2] eal: fix build with glibc < 2.16
Date: Mon, 30 Apr 2018 09:13:29 -0400 [thread overview]
Message-ID: <f7tpo2g7s7a.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <20180427024342.24054-2-thomas@monjalon.net> (Thomas Monjalon's message of "Fri, 27 Apr 2018 04:43:41 +0200")
Thomas Monjalon <thomas@monjalon.net> writes:
> The fake getauxval function does not use its parameter.
> So the compiler raised this error:
> lib/librte_eal/common/eal_common_cpuflags.c:25:25: error:
> unused parameter 'type'
>
> Fixes: 2ed9bf330709 ("eal: abstract away the auxiliary vector")
> Cc: aconole@redhat.com
> Cc: tredaelli@redhat.com
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Oops - sorry about that.
Acked-by: Aaron Conole <aconole@redhat.com>
> lib/librte_eal/common/eal_common_cpuflags.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/eal_common_cpuflags.c b/lib/librte_eal/common/eal_common_cpuflags.c
> index a09667563..6a9dbaeb1 100644
> --- a/lib/librte_eal/common/eal_common_cpuflags.c
> +++ b/lib/librte_eal/common/eal_common_cpuflags.c
> @@ -22,7 +22,7 @@
>
> #ifndef HAS_AUXV
> static unsigned long
> -getauxval(unsigned long type)
> +getauxval(unsigned long type __rte_unused)
> {
> errno = ENOTSUP;
> return 0;
next prev parent reply other threads:[~2018-04-30 13:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 2:43 [dpdk-dev] [PATCH 0/2] fix compilation on FreeBSD Thomas Monjalon
2018-04-27 2:43 ` [dpdk-dev] [PATCH 1/2] eal: fix build with glibc < 2.16 Thomas Monjalon
2018-04-30 13:13 ` Aaron Conole [this message]
2018-04-27 2:43 ` [dpdk-dev] [PATCH 2/2] eal: fix build on FreeBSD Thomas Monjalon
2018-04-30 13:17 ` Aaron Conole
2018-04-27 9:03 ` [dpdk-dev] [PATCH 0/2] fix compilation " Maxime Coquelin
2018-04-27 9:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tpo2g7s7a.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=tredaelli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).