From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net,
Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [PATCH] ci: run more checks in private repositories
Date: Fri, 25 Mar 2022 10:32:38 -0400 [thread overview]
Message-ID: <f7tsfr69k6x.fsf@redhat.com> (raw)
In-Reply-To: <20220324145343.24485-1-david.marchand@redhat.com> (David Marchand's message of "Thu, 24 Mar 2022 15:53:42 +0100")
David Marchand <david.marchand@redhat.com> writes:
> Though devtools/checkpatches.sh is run as part of our CI, some other
> (not well known) checks could help when run in private repositories
> before submitting to the mailing list and even when run from the
> ovsrobot.
>
> Most of them require a git history or checked sources to run.
> And I can't guarantee there won't be false positives.
>
> Add a new job just for those checks so that it won't block compilation
> tests in other jobs.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Looks good to me. The extra fetches shouldn't take too long (since we
refresh main branch weekly to the robot repository). The checks look
good - and since it's part of the same build workflow, it will be
reported in the same place (and hopefully in a readable form).
Acked-by: Aaron Conole <aconole@redhat.com>
next prev parent reply other threads:[~2022-03-25 14:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 14:53 David Marchand
2022-03-25 14:32 ` Aaron Conole [this message]
2022-04-28 12:12 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tsfr69k6x.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maicolgabriel@hotmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).