From: Aaron Conole <aconole@redhat.com>
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: pbhagavatula@caviumnetworks.com, harry.van.haaren@intel.com,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/1] eal: return true or false from lcore role check function
Date: Tue, 09 Jan 2018 11:44:39 -0500 [thread overview]
Message-ID: <f7ttvvv3rt4.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <1515005015-31990-2-git-send-email-erik.g.carrillo@intel.com> (Erik Gabriel Carrillo's message of "Wed, 3 Jan 2018 12:43:35 -0600")
Hi Erik,
Erik Gabriel Carrillo <erik.g.carrillo@intel.com> writes:
> Update rte_lcore_has_role() so that it returns true/false instead of
> success/failure.
>
> Fixes: 78666372fa2b ("eal: add function to check lcore role")
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
I believe this breaks the published abi - Success is now 'true', and
failure is 'false'; previously success would be 0 == false. You'll
need to invert the test, or note that the abi is breaking (since
semantically any caller will need to invert the test).
next prev parent reply other threads:[~2018-01-09 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 18:43 [dpdk-dev] [PATCH 0/1] " Erik Gabriel Carrillo
2018-01-03 18:43 ` [dpdk-dev] [PATCH 1/1] " Erik Gabriel Carrillo
2018-01-04 8:47 ` Pavan Nikhilesh
2018-01-09 16:44 ` Aaron Conole [this message]
2018-01-11 23:09 ` Carrillo, Erik G
2018-01-11 23:17 ` Thomas Monjalon
2018-01-12 18:01 ` Carrillo, Erik G
2018-01-12 18:04 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ttvvv3rt4.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).