From: Aaron Conole <aconole@redhat.com>
To: "Ananyev\, Konstantin" <konstantin.ananyev@intel.com>
Cc: "Pattan\, Reshma" <reshma.pattan@intel.com>,
"dev\@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v6 5/8] lib/librte_pdump: add new library for packet capturing support
Date: Thu, 09 Jun 2016 13:23:51 -0400 [thread overview]
Message-ID: <f7ttwh2numw.fsf@redhat.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B6DAC0@irsmsx105.ger.corp.intel.com> (Konstantin Ananyev's message of "Thu, 9 Jun 2016 16:05:34 +0000")
"Ananyev, Konstantin" <konstantin.ananyev@intel.com> writes:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Aaron Conole
>> Sent: Thursday, June 09, 2016 4:59 PM
>> To: Pattan, Reshma
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v6 5/8] lib/librte_pdump: add new
> library for packet capturing support
>>
>> Reshma Pattan <reshma.pattan@intel.com> writes:
>>
>> > Added new library for packet capturing support.
>> >
>> > Added public api rte_pdump_init, applications should call
>> > this as part of their application setup to have packet
>> > capturing framework ready.
>> >
>> > Added public api rte_pdump_uninit to uninitialize the packet
>> > capturing framework.
>> >
>> > Added public apis rte_pdump_enable and rte_pdump_disable to
>> > enable and disable packet capturing on specific port and queue.
>> >
>> > Added public apis rte_pdump_enable_by_deviceid and
>> > rte_pdump_disable_by_deviceid to enable and disable packet
>> > capturing on a specific device (pci address or name) and queue.
>> >
>> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
>> > ---
>> > +
>> > +int
>> > +rte_pdump_init(void)
>>
>> Would you be opposed to having an argument here which takes a path to
>> the server socket? That way the application can have some control over
>> the server socket location rather than using the guesses from
>> pdump_get_socket_path.
>
> I suppose it is better to keep IPC mechanism details internal for the
> pdump library.
> That way upper layer don't need to know what is that and write the
> code to open/maintain it.
> Again, that gives pdump library a freedom to change it (if needed) or
> possibly introduce some alternatives.
> Konstantin
>
How does the application change it? The details do matter here, as some
applications (ex: openvswitch) have specific policies on which files
files get opened and where those files exist. That has impact on things
like selinux and other access control technology.
If I missed the API that lets apps redirect the output, please correct me,
but so far I don't think I've missed it. pdump still can change a
default, but it would be good to give a method for guiding the final
choice of file to open.
-Aaron
next prev parent reply other threads:[~2016-06-09 17:23 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 10:55 [dpdk-dev] [PATCH 0/5] add packet capture framework Reshma Pattan
2016-05-06 10:55 ` [dpdk-dev] [PATCH 1/5] librte_ether: protect add/remove of rxtx callbacks with spinlocks Reshma Pattan
2016-05-06 10:55 ` [dpdk-dev] [PATCH 2/5] lib/librte_pdump: add new library for packet capturing support Reshma Pattan
2016-05-06 10:55 ` [dpdk-dev] [PATCH 3/5] app/pdump: add pdump tool for packet capturing Reshma Pattan
2016-05-06 10:55 ` [dpdk-dev] [PATCH 4/5] app/test-pmd: add pdump initialization uninitialization Reshma Pattan
2016-05-06 10:55 ` [dpdk-dev] [PATCH 5/5] doc: update doc for packet capture framework Reshma Pattan
2016-05-10 9:39 ` [dpdk-dev] [PATCHv2 0/5] add " Reshma Pattan
2016-05-10 9:39 ` [dpdk-dev] [PATCHv2 1/5] librte_ether: protect add/remove of rxtx callbacks with spinlocks Reshma Pattan
2016-05-10 9:39 ` [dpdk-dev] [PATCHv2 2/5] lib/librte_pdump: add new library for packet capturing support Reshma Pattan
2016-05-10 9:40 ` [dpdk-dev] [PATCHv2 3/5] app/pdump: add pdump tool for packet capturing Reshma Pattan
2016-05-10 9:40 ` [dpdk-dev] [PATCHv2 4/5] app/test-pmd: add pdump initialization uninitialization Reshma Pattan
2016-05-10 9:40 ` [dpdk-dev] [PATCHv2 5/5] doc: update doc for packet capture framework Reshma Pattan
2016-05-10 10:13 ` [dpdk-dev] [PATCHv2 0/5] add " Remy Horton
2016-05-17 16:37 ` [dpdk-dev] [PATCH v3 0/8] " Reshma Pattan
2016-05-17 16:37 ` [dpdk-dev] [PATCH v3 1/8] librte_ether: protect add/remove of rxtx callbacks with spinlocks Reshma Pattan
2016-05-17 16:37 ` [dpdk-dev] [PATCH v3 2/8] librte_ether: add new api rte_eth_add_first_rx_callback Reshma Pattan
2016-05-17 16:37 ` [dpdk-dev] [PATCH v3 3/8] librte_ether: add new fields to rte_eth_dev_info struct Reshma Pattan
2016-05-17 16:37 ` [dpdk-dev] [PATCH v3 4/8] librte_ether: make rte_eth_dev_get_port_by_name api public Reshma Pattan
2016-05-17 16:37 ` [dpdk-dev] [PATCH v3 5/8] lib/librte_pdump: add new library for packet capturing support Reshma Pattan
2016-05-17 16:37 ` [dpdk-dev] [PATCH v3 6/8] app/pdump: add pdump tool for packet capturing Reshma Pattan
2016-05-17 16:37 ` [dpdk-dev] [PATCH v3 7/8] app/test-pmd: add pdump initialization uninitialization Reshma Pattan
2016-05-17 16:37 ` [dpdk-dev] [PATCH v3 8/8] doc: update doc for packet capture framework Reshma Pattan
2016-05-23 21:38 ` [dpdk-dev] [PATCH v4 0/9] add " Reshma Pattan
2016-05-23 21:38 ` [dpdk-dev] [PATCH v4 1/9] librte_ether: protect add/remove of rxtx callbacks with spinlocks Reshma Pattan
2016-05-23 21:38 ` [dpdk-dev] [PATCH v4 2/9] librte_ether: add new api rte_eth_add_first_rx_callback Reshma Pattan
2016-05-23 21:38 ` [dpdk-dev] [PATCH v4 3/9] librte_ether: add new fields to rte_eth_dev_info struct Reshma Pattan
2016-05-23 22:24 ` Stephen Hemminger
2016-05-24 8:09 ` Pattan, Reshma
2016-05-23 21:38 ` [dpdk-dev] [PATCH v4 4/9] librte_ether: make rte_eth_dev_get_port_by_name api public Reshma Pattan
2016-05-23 21:38 ` [dpdk-dev] [PATCH v4 5/9] lib/librte_pdump: add new library for packet capturing support Reshma Pattan
2016-05-27 13:39 ` Ananyev, Konstantin
2016-05-27 14:54 ` Pattan, Reshma
2016-05-27 15:25 ` Ananyev, Konstantin
2016-05-31 14:55 ` Pattan, Reshma
2016-05-31 15:00 ` Pattan, Reshma
2016-05-23 21:38 ` [dpdk-dev] [PATCH v4 6/9] app/pdump: add pdump tool for packet capturing Reshma Pattan
2016-05-27 15:21 ` Ananyev, Konstantin
2016-05-31 14:50 ` Pattan, Reshma
2016-05-31 17:21 ` Ananyev, Konstantin
2016-06-02 12:31 ` Pattan, Reshma
2016-06-02 14:22 ` Ananyev, Konstantin
2016-05-23 21:38 ` [dpdk-dev] [PATCH v4 7/9] app/test-pmd: add pdump initialization uninitialization Reshma Pattan
2016-05-23 21:38 ` [dpdk-dev] [PATCH v4 8/9] doc: update doc for packet capture framework Reshma Pattan
2016-05-23 21:38 ` [dpdk-dev] [PATCH v4 9/9] doc: announce ABI change for rte_eth_dev_info structure Reshma Pattan
2016-05-26 8:15 ` [dpdk-dev] [PATCH v4 0/9] add packet capture framework Thomas Monjalon
2016-06-08 13:38 ` [dpdk-dev] [PATCH v5 " Reshma Pattan
2016-06-08 13:38 ` [dpdk-dev] [PATCH v5 1/9] librte_ether: protect add/remove of rxtx callbacks with spinlocks Reshma Pattan
2016-06-08 13:38 ` [dpdk-dev] [PATCH v5 2/9] librte_ether: add new api rte_eth_add_first_rx_callback Reshma Pattan
2016-06-08 13:38 ` [dpdk-dev] [PATCH v5 3/9] librte_ether: add new fields to rte_eth_dev_info struct Reshma Pattan
2016-06-08 13:38 ` [dpdk-dev] [PATCH v5 4/9] librte_ether: make rte_eth_dev_get_port_by_name rte_eth_dev_get_name_by_port public Reshma Pattan
2016-06-08 13:38 ` [dpdk-dev] [PATCH v5 5/9] lib/librte_pdump: add new library for packet capturing support Reshma Pattan
2016-06-08 13:38 ` [dpdk-dev] [PATCH v5 6/9] app/pdump: add pdump tool for packet capturing Reshma Pattan
2016-06-08 13:38 ` [dpdk-dev] [PATCH v5 7/9] app/test-pmd: add pdump initialization uninitialization Reshma Pattan
2016-06-08 13:38 ` [dpdk-dev] [PATCH v5 8/9] doc: update doc for packet capture framework Reshma Pattan
2016-06-08 16:02 ` Mcnamara, John
2016-06-08 13:38 ` [dpdk-dev] [PATCH v5 9/9] doc: announce ABI change for rte_eth_dev_info structure Reshma Pattan
2016-06-08 16:15 ` Mcnamara, John
2016-06-09 8:50 ` [dpdk-dev] [PATCH v6 0/8] add packet capture framework Reshma Pattan
2016-06-09 8:50 ` [dpdk-dev] [PATCH v6 1/8] librte_ether: protect add/remove of rxtx callbacks with spinlocks Reshma Pattan
2016-06-09 8:50 ` [dpdk-dev] [PATCH v6 2/8] librte_ether: add new api rte_eth_add_first_rx_callback Reshma Pattan
2016-06-09 8:50 ` [dpdk-dev] [PATCH v6 3/8] librte_ether: add new fields to rte_eth_dev_info struct Reshma Pattan
2016-06-09 8:50 ` [dpdk-dev] [PATCH v6 4/8] librte_ether: make rte_eth_dev_get_port_by_name rte_eth_dev_get_name_by_port public Reshma Pattan
2016-06-09 8:50 ` [dpdk-dev] [PATCH v6 5/8] lib/librte_pdump: add new library for packet capturing support Reshma Pattan
2016-06-09 15:59 ` Aaron Conole
2016-06-09 16:05 ` Ananyev, Konstantin
2016-06-09 17:23 ` Aaron Conole [this message]
2016-06-09 19:32 ` Ananyev, Konstantin
2016-06-09 19:56 ` Aaron Conole
2016-06-10 16:22 ` Pattan, Reshma
2016-06-09 8:50 ` [dpdk-dev] [PATCH v6 6/8] app/pdump: add pdump tool for packet capturing Reshma Pattan
2016-06-09 8:50 ` [dpdk-dev] [PATCH v6 7/8] app/test-pmd: add pdump initialization uninitialization Reshma Pattan
2016-06-09 8:50 ` [dpdk-dev] [PATCH v6 8/8] doc: update doc for packet capture framework Reshma Pattan
2016-06-09 16:10 ` [dpdk-dev] [PATCH v7 0/8] add " Reshma Pattan
2016-06-09 16:10 ` [dpdk-dev] [PATCH v7 1/8] librte_ether: protect add/remove of rxtx callbacks with spinlocks Reshma Pattan
2016-06-09 16:10 ` [dpdk-dev] [PATCH v7 2/8] librte_ether: add new api rte_eth_add_first_rx_callback Reshma Pattan
2016-06-09 16:10 ` [dpdk-dev] [PATCH v7 3/8] librte_ether: add new fields to rte_eth_dev_info struct Reshma Pattan
2016-06-09 16:10 ` [dpdk-dev] [PATCH v7 4/8] librte_ether: make rte_eth_dev_get_port_by_name rte_eth_dev_get_name_by_port public Reshma Pattan
2016-06-09 16:10 ` [dpdk-dev] [PATCH v7 5/8] lib/librte_pdump: add new library for packet capturing support Reshma Pattan
2016-06-09 16:10 ` [dpdk-dev] [PATCH v7 6/8] app/pdump: add pdump tool for packet capturing Reshma Pattan
2016-06-09 16:10 ` [dpdk-dev] [PATCH v7 7/8] app/test-pmd: add pdump initialization uninitialization Reshma Pattan
2016-06-09 16:10 ` [dpdk-dev] [PATCH v7 8/8] doc: update doc for packet capture framework Reshma Pattan
2016-06-09 17:34 ` [dpdk-dev] [PATCH v7 0/8] add " Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ttwh2numw.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).