From: Brice Goglin <Brice.Goglin@inria.fr>
To: Stephen Hemminger <stephen@networkplumber.org>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
david.marchand@redhat.com
Subject: Re: [PATCH] usertools: enhance CPU layout
Date: Mon, 24 Apr 2023 19:05:54 +0200 [thread overview]
Message-ID: <f83c635f-cd58-a274-d4ed-4ef636030add@inria.fr> (raw)
In-Reply-To: <20230421081515.3eca928d@hermes.local>
[-- Attachment #1.1: Type: text/plain, Size: 1622 bytes --]
Le 21/04/2023 à 17:15, Stephen Hemminger a écrit :
>
>>> Better to understand more about our opinion of this script before send a v2 patch.
>>> I've used 'lstopo'. It's a great tool.
>>> To my opinion, considering there're Linux tools to show all kinds of information, the reason that DPDK has its own tool is to summarize and emphasize the information that is important to DPDK. Here it's that some cores are more powerful than others. When the users use a testpmd-like APP, they can choose the appropriate cores after DPDK reminds them about the difference between cores.
>>> Add Thomas for more suggestions. Thanks.
>> Adding Brice, hwloc maintainer.
>>
>> I think it would be better to contribute to the hwloc project.
>> If we need a different set of info, we can probably tune it with options.
> The script had a purpose which was back when DPDK was first started.
> But as systems get more complex, it becomes something that has to deal with lots
> of corner cases; and if some other tool can it then that is better.
Hello
Indeed, hwloc/lstopo should be able to do something similar to that
script. I didn't see anything network-related in the script, does it
only show CPU info?
Regarding the original patch, we already support all levels or caches,
dies, clusters, etc. Hybrid CPUs are also detected but they are only
nicely shown in the graphical output [1]. The textual output only says
at the very end that there are two kinds and the bitmask of CPUs for
each. I am open to improving this.
Brice
[1] https://twitter.com/bgoglin/status/1542117836008706049/photo/1
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2023-04-26 6:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 5:25 Wenzhuo Lu
2023-04-18 16:31 ` Stephen Hemminger
2023-04-18 16:46 ` Stephen Hemminger
2023-04-21 1:47 ` Lu, Wenzhuo
2023-04-21 8:28 ` Thomas Monjalon
2023-04-21 15:15 ` Stephen Hemminger
2023-04-24 17:05 ` Brice Goglin [this message]
2023-04-25 5:29 ` Lu, Wenzhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f83c635f-cd58-a274-d4ed-4ef636030add@inria.fr \
--to=brice.goglin@inria.fr \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).