From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Shani Peretz <shperetz@nvidia.com>, dev@dpdk.org
Cc: mkashani@nvidia.com, Ori Kam <orika@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Gregory Etelson <getelson@nvidia.com>,
"ci@dpdk.org" <ci@dpdk.org>
Subject: Re: [PATCH] app/testpmd: fix auto completion for indirect list action
Date: Tue, 19 Mar 2024 15:29:53 +0000 [thread overview]
Message-ID: <f90f35f8-fd59-49cf-b3b6-02878104e7a2@amd.com> (raw)
In-Reply-To: <62669854-8add-4fdd-b882-a63d78f0d6e8@amd.com>
On 3/19/2024 2:51 PM, Ferruh Yigit wrote:
> On 3/18/2024 9:21 AM, Shani Peretz wrote:
>> In the process of auto completion of a command in testpmd,
>> the parser splits the command into tokens, where each token
>> represents an argument and defines a parsing function.
>> The parsing function of the indirect_list action argument was returning
>> before having the opportunity to handle the argument.
>>
> Hi Shani,
>
> I can see a few other handles follows the updated logic, but to
> understand more, was the problematic part following:
> ```
> if (!action)
> return -1;
> ```
>
> If so why 'action' can be NULL and why need to continue for this case,
> can you please help me understand?
>
> Also even if 'action' is NULL, function will return output of
> 'parse_int()', is this expected?
>
I can verify the fix via debugging,
it seems missing ".comp = comp_none" cause calling handler
(parse_indlst_id2ptr), and 'parse_indlst_id2ptr()' needs to be fixed to
parse correctly.
I will proceed with patch since it is local to a specific flow command,
BUT overall how can we catch issues like this in the feature, we don't
have a good way to test testpmd flow commands.
@Ori, @Gregory, do you have any idea?
cc'ed CI mail list too.
next parent reply other threads:[~2024-03-19 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240318092109.87656-1-shperetz@nvidia.com>
[not found] ` <62669854-8add-4fdd-b882-a63d78f0d6e8@amd.com>
2024-03-19 15:29 ` Ferruh Yigit [this message]
2024-03-20 6:06 ` Gregory Etelson
2024-03-20 10:08 ` Ferruh Yigit
2024-03-20 20:25 ` Patrick Robb
2024-03-23 10:09 ` Gregory Etelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f90f35f8-fd59-49cf-b3b6-02878104e7a2@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=ci@dpdk.org \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=orika@nvidia.com \
--cc=shperetz@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).