From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org, Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH 1/4] app/testpmd: add queue deferred start switch
Date: Mon, 3 Sep 2018 17:56:55 +0100 [thread overview]
Message-ID: <f9c93226-1bf5-4f56-6eec-71c164dd1718@intel.com> (raw)
In-Reply-To: <1535526966-32456-2-git-send-email-arybchenko@solarflare.com>
On 8/29/2018 8:16 AM, Andrew Rybchenko wrote:
> From: Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>
>
> Signed-off-by: Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> app/test-pmd/cmdline.c | 91 ++++++++++++++++++++++++++
> doc/guides/rel_notes/release_18_11.rst | 6 ++
> 2 files changed, 97 insertions(+)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 589121d69..f47ec99f1 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -883,6 +883,10 @@ static void cmd_help_long_parsed(void *parsed_result,
> " Start/stop a rx/tx queue of port X. Only take effect"
> " when port X is started\n\n"
>
> + "port (port_id) (rxq|txq) (queue_id) deferred_start (on|off)\n"
> + " Switch on/off a deferred start of port X rx/tx queue. Only"
> + " take effect when port X is stopped.\n\n"
Overall looks good to me.
But testpmd doc needs to be updated to add new command.
doc/guides/testpmd_app_ug/testpmd_funcs.rst
Also is there a way to see the current deferred_start status of a port, either
with a specific command or as part of other command like "show port info"?
If not does it make sense to have a way to see it?
next prev parent reply other threads:[~2018-09-03 16:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 7:16 [dpdk-dev] [PATCH 0/4] net/failsafe: support deferred queue start Andrew Rybchenko
2018-08-29 7:16 ` [dpdk-dev] [PATCH 1/4] app/testpmd: add queue deferred start switch Andrew Rybchenko
2018-09-03 16:56 ` Ferruh Yigit [this message]
2018-09-20 13:24 ` Andrew Rybchenko
2018-08-29 7:16 ` [dpdk-dev] [PATCH 2/4] net/failsafe: add checks for deferred queue setup Andrew Rybchenko
2018-08-29 7:16 ` [dpdk-dev] [PATCH 3/4] net/failsafe: add Rx queue start and stop functions Andrew Rybchenko
2018-08-29 7:16 ` [dpdk-dev] [PATCH 4/4] net/failsafe: add Tx " Andrew Rybchenko
2018-08-29 9:35 ` [dpdk-dev] [PATCH 0/4] net/failsafe: support deferred queue start Gaëtan Rivet
2018-09-20 13:55 ` [dpdk-dev] [PATCH v2 " Andrew Rybchenko
2018-09-20 13:55 ` [dpdk-dev] [PATCH v2 1/4] app/testpmd: add queue deferred start switch Andrew Rybchenko
2018-09-20 13:55 ` [dpdk-dev] [PATCH v2 2/4] net/failsafe: add checks for deferred queue setup Andrew Rybchenko
2018-09-20 13:55 ` [dpdk-dev] [PATCH v2 3/4] net/failsafe: add Rx queue start and stop functions Andrew Rybchenko
2018-09-20 13:55 ` [dpdk-dev] [PATCH v2 4/4] net/failsafe: add Tx " Andrew Rybchenko
2018-09-21 0:21 ` [dpdk-dev] [PATCH v2 0/4] net/failsafe: support deferred queue start Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9c93226-1bf5-4f56-6eec-71c164dd1718@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Ian.Dolzhansky@oktetlabs.ru \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).