From: Sinan Kaya <okaya@kernel.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Graham Whyte <grwhyte@microsoft.com>
Subject: Re: [PATCH v4 2/8] eal: fixes for re-initialization issues
Date: Tue, 15 Aug 2023 14:35:23 -0400 [thread overview]
Message-ID: <f9d4e3db24aa5b192b0e85d24ace3e63c7f75a78.camel@kernel.org> (raw)
In-Reply-To: <20230815104906.4e55df8b@hermes.local>
On Tue, 2023-08-15 at 10:49 -0700, Stephen Hemminger wrote:
> >
> > + __atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);
> > return 0;
>
>
> Interesting, other flags don't use atomic. Why here?
>
>
>
> And is already set elsewhere?
Looking at the history, this variable used to be an atomic
variable. Later, it got replaced with a uint32_t and write
is done with __atomic_store_n instead. I followed other
examples in the same source code file.
next prev parent reply other threads:[~2023-08-15 18:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 14:50 [PATCH v4 0/8] support reinit flow okaya
2023-08-15 14:50 ` [PATCH v4 1/8] eal: cleanup plugins data okaya
2023-08-15 14:50 ` [PATCH v4 2/8] eal: fixes for re-initialization issues okaya
2023-08-15 17:49 ` Stephen Hemminger
2023-08-15 18:35 ` Sinan Kaya [this message]
2023-08-15 14:50 ` [PATCH v4 3/8] tailq: skip init if already initialized okaya
2023-08-15 14:50 ` [PATCH v4 4/8] eal_memzone: bail out on initialized okaya
2023-08-15 14:50 ` [PATCH v4 5/8] memseg: init once okaya
2023-08-15 14:50 ` [PATCH v4 6/8] eal_memory: skip initialization okaya
2023-08-15 14:50 ` [PATCH v4 7/8] eal_interrupts: don't reinitialize threads okaya
2023-08-15 17:47 ` Stephen Hemminger
2023-08-15 14:50 ` [PATCH v4 8/8] eal: initialize worker threads once okaya
2023-08-15 17:46 ` Stephen Hemminger
2023-08-15 18:43 ` Sinan Kaya
2023-08-15 17:45 ` [PATCH v4 0/8] support reinit flow Stephen Hemminger
2023-08-15 18:58 ` Sinan Kaya
2023-08-15 19:47 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9d4e3db24aa5b192b0e85d24ace3e63c7f75a78.camel@kernel.org \
--to=okaya@kernel.org \
--cc=dev@dpdk.org \
--cc=grwhyte@microsoft.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).