From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Gaetan Rivet <gaetan.rivet@6wind.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal/option: fix option register duplicate detection
Date: Mon, 17 Dec 2018 09:35:45 +0000 [thread overview]
Message-ID: <f9e0369f-5f63-caec-8964-c172586c3a6f@intel.com> (raw)
In-Reply-To: <20181217092559.21801-1-gaetan.rivet@6wind.com>
On 17-Dec-18 9:25 AM, Gaetan Rivet wrote:
> Missing brackets around the if means that the loop will end at its first
> iteration.
>
> Cc: stable@dpdk.org
>
> Fixes: 2395332798d0 ("eal: add option register infrastructure")
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> lib/librte_eal/common/rte_option.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/rte_option.c b/lib/librte_eal/common/rte_option.c
> index 02d59a869..eefb8b923 100644
> --- a/lib/librte_eal/common/rte_option.c
> +++ b/lib/librte_eal/common/rte_option.c
> @@ -35,10 +35,11 @@ void __rte_experimental
> rte_option_register(struct rte_option *opt)
> {
> TAILQ_FOREACH(option, &rte_option_list, next) {
> - if (strcmp(opt->opt_str, option->opt_str) == 0)
> + if (strcmp(opt->opt_str, option->opt_str) == 0) {
> RTE_LOG(INFO, EAL, "Option %s has already been registered.",
> opt->opt_str);
> return;
> + }
> }
>
> TAILQ_INSERT_HEAD(&rte_option_list, opt, next);
>
This is why i don't like the "no brackets on single-statement if clause"
rule in our coding style guide - it makes mistakes like these easier to
do. This wouldn't have happened if we mandated to have brackets always,
for everything.
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-12-17 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 9:25 [dpdk-stable] " Gaetan Rivet
2018-12-17 9:35 ` Burakov, Anatoly [this message]
2018-12-17 10:19 ` [dpdk-stable] [dpdk-dev] " David Marchand
2018-12-19 22:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9e0369f-5f63-caec-8964-c172586c3a6f@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).