DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] ip_chksum not updated in ipsec-secgw application
Date: Mon, 18 Jul 2016 19:19:32 +0530	[thread overview]
Message-ID: <fab56386-2e39-f845-8db7-473a5595ab7e@nxp.com> (raw)
In-Reply-To: <61dc3eb1-2522-78f5-871d-442d473ab69d@intel.com>

On 7/18/2016 6:27 PM, Sergio Gonzalez Monroy wrote:
> Hi,
>
> On 18/07/2016 13:41, Akhil Goyal wrote:
>> Hi,
>>
>> In Ipsec-secgw application, while adding the outer IP header, it seems
>> that the application does not update the checksum value for outbound
>> packets. This result in incorrect ip->checksum in the encrypted packet.
>>
>> Please let me know if the checksum value is updated somewhere else or
>> not.
>>
>> Also In case of inner ip header also the TTL value is decremented by
>> one but the checksum value is not updated. Is it intentional or it is
>> done somewhere else?
>
> It is intentional. The application is using IP checksum offload but just
> looking now at the code there is a bug for IPv6 packets where the flag
> does not get setup.
> Is it only for IPv6 traffic that you are having this issue?
>
> For IPv4 traffic the PKT_TX_IP_CKSUM flag is setup in 'prepare_tx_pkt'
> function in ipsec-secgw.c
>
> Sergio
>

Thanks Sergio, got your point. I missed the flag. I was using it for IPv4.

Akhil

  parent reply	other threads:[~2016-07-18 13:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-18 12:41 Akhil Goyal
2016-07-18 12:57 ` Sergio Gonzalez Monroy
2016-07-18 13:20   ` Thomas Monjalon
2016-07-18 13:53     ` Akhil Goyal
2016-07-18 13:57       ` Sergio Gonzalez Monroy
2016-07-18 14:09         ` Thomas Monjalon
2016-07-18 14:25           ` Sergio Gonzalez Monroy
2016-07-18 13:49   ` Akhil Goyal [this message]
2016-07-18 14:00     ` Sergio Gonzalez Monroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fab56386-2e39-f845-8db7-473a5595ab7e@nxp.com \
    --to=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=sergio.gonzalez.monroy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).