From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Qi Zhang <qi.z.zhang@intel.com>,
jingjing.wu@intel.com, helin.zhang@intel.com,
Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix wrong device flag setup
Date: Tue, 7 Feb 2017 10:32:32 +0000 [thread overview]
Message-ID: <fb52d206-8464-baf3-dfa2-24fb208c2a3b@intel.com> (raw)
In-Reply-To: <736135ef-b9cf-cd6e-1dfc-ecba9d63e114@intel.com>
On 2/7/2017 10:24 AM, Ferruh Yigit wrote:
> On 2/3/2017 11:36 PM, Qi Zhang wrote:
>> dev_flags is wrong overwritten by RTE_ETH_DEV_DETACHABLE after
>> rte_eth_copy_pci_info.
>>
>> Fixes: 22dda618c00c ("pci: separate detaching ethernet ports from PCI devices")
>>
>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>> ---
>> drivers/net/bnxt/bnxt_ethdev.c | 2 +-
>> drivers/net/e1000/igb_ethdev.c | 4 ++--
>> drivers/net/fm10k/fm10k_ethdev.c | 2 +-
>> drivers/net/i40e/i40e_ethdev.c | 2 +-
>> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>> drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++--
>> drivers/net/nfp/nfp_net.c | 2 +-
>> drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-
>> 8 files changed, 10 insertions(+), 10 deletions(-)
>>
>
> Hi Qi,
>
> Thanks for the fix.
>
> Is following missed, or intentionally excluded:
>
> drivers/net/e1000/em_ethdev.c
> drivers/net/virtio/virtio_ethdev.c
Hi Yuanhan,
I saw while checking for this, there can be an issue in virtio for this
path, can you please check:
eth_virtio_dev_init()
set-some-eth_dev-dev_flags
virtio_init_device()
rte_eth_copy_pci_info()
eth_dev->data->dev_flags = 0; <---- Reset previous flags
Regards,
ferruh
next prev parent reply other threads:[~2017-02-07 10:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 23:36 Qi Zhang
2017-02-07 10:24 ` Ferruh Yigit
2017-02-07 10:32 ` Ferruh Yigit [this message]
2017-02-08 1:49 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb52d206-8464-baf3-dfa2-24fb208c2a3b@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).