From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: sunwenjie <findtheonlyway@gmail.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] vhost: fix deadlock when vhost unregister
Date: Thu, 21 Feb 2019 18:46:55 +0100 [thread overview]
Message-ID: <fb9692f2-4245-92f8-53a0-609f7711634c@redhat.com> (raw)
In-Reply-To: <20190128065549.98266-1-findtheonlyway@gmail.com>
On 1/28/19 7:55 AM, sunwenjie wrote:
> When rte_vhost_driver_unregister delete the connection fd,
> fdset_try_del will always try and donot release the
> vhostuser.mutex if the fd is busy, but the fdset_event_dispatch
> will set the fd to busy and call vhost_user_msg_handler to get
> vhostuser.mutex, which will cause deadlock. Unlock the
> vhost_user.mutexif fdset_try_del fail and relock it when retry.
>
> Fixes: 8b4b949144b8 ("vhost: fix dead lock on closing in server mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: sunwenjie <findtheonlyway@gmail.com>
> ---
> lib/librte_vhost/socket.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Applied to dpdk-next-virtio/master with suggested commit message
rewording, and fixed Signed-off-by name.
Thanks,
Maxime
prev parent reply other threads:[~2019-02-21 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 6:55 [dpdk-stable] " sunwenjie
2019-02-08 14:12 ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
2019-02-14 4:05 ` 孙文杰
2019-02-21 17:46 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb9692f2-4245-92f8-53a0-609f7711634c@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=findtheonlyway@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).