From: "Morrissey, Sean" <sean.morrissey@intel.com>
To: Jasvinder Singh <jasvinder.singh@intel.com>, <dev@dpdk.org>
Cc: <aman.deep.singh@intel.com>, <yuying.zhang@intel.com>, <stable@dpdk.org>
Subject: Re: [PATCH] app/testpmd: fix memory leak for dscp table
Date: Wed, 29 Jun 2022 16:37:02 +0100 [thread overview]
Message-ID: <fce14df9-2faa-64b7-e74a-76b6b59ef930@intel.com> (raw)
In-Reply-To: <20220628132916.1284235-1-jasvinder.singh@intel.com>
Reviewed-by: Sean Morrissey <sean.morrissey@intel.com>
Thanks.
On 28/06/2022 14:29, Jasvinder Singh wrote:
> This patch fixes memory leak reported by coverity.
>
> Coverity issue: 379220
> Fixes: 9f5488e326d3 ("app/testpmd: support different input color method")
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
> app/test-pmd/cmdline_mtr.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c
> index b92e66cedb..833273da0d 100644
> --- a/app/test-pmd/cmdline_mtr.c
> +++ b/app/test-pmd/cmdline_mtr.c
> @@ -131,8 +131,10 @@ parse_input_color_table_entries(char *str, enum rte_color **dscp_table,
> /* Allocate memory for vlan table */
> vlan = (enum rte_color *)malloc(MAX_VLAN_TABLE_ENTRIES *
> sizeof(enum rte_color));
> - if (vlan == NULL)
> + if (vlan == NULL) {
> + free(*dscp_table);
> return -1;
> + }
>
> i = 0;
> while (1) {
> @@ -144,6 +146,7 @@ parse_input_color_table_entries(char *str, enum rte_color **dscp_table,
> vlan[i++] = RTE_COLOR_RED;
> else {
> free(vlan);
> + free(*dscp_table);
> return -1;
> }
> if (i == MAX_VLAN_TABLE_ENTRIES)
> @@ -152,6 +155,7 @@ parse_input_color_table_entries(char *str, enum rte_color **dscp_table,
> token = strtok_r(str, PARSE_DELIMITER, &str);
> if (token == NULL) {
> free(vlan);
> + free(*dscp_table);
> return -1;
> }
> }
next prev parent reply other threads:[~2022-06-29 15:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 13:29 Jasvinder Singh
2022-06-29 15:37 ` Morrissey, Sean [this message]
2022-06-29 16:53 ` Singh, Aman Deep
2022-06-29 17:24 ` Singh, Jasvinder
2022-06-29 17:30 ` Singh, Aman Deep
2022-07-06 14:32 ` Andrew Rybchenko
2022-07-07 12:39 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fce14df9-2faa-64b7-e74a-76b6b59ef930@intel.com \
--to=sean.morrissey@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=stable@dpdk.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).