From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Sergey Vyazmitinov <s.vyazmitinov@brain4net.com>
Cc: olivier.matz@6wind.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: use bulk functions to allocate and free mbufs
Date: Wed, 11 Jan 2017 17:00:52 +0000 [thread overview]
Message-ID: <fe15a2b1-b7a4-537a-e779-cb06954a23b6@intel.com> (raw)
In-Reply-To: <20170111081759.7b1ee146@xeon-e3>
Hi Sergey,
On 1/11/2017 4:17 PM, Stephen Hemminger wrote:
> On Fri, 30 Dec 2016 04:50:16 +0700
> Sergey Vyazmitinov <s.vyazmitinov@brain4net.com> wrote:
>
>> /**
>> + * Free n packets mbuf back into its original mempool.
>> + *
>> + * Free each mbuf, and all its segments in case of chained buffers. Each
>> + * segment is added back into its original mempool.
>> + *
>> + * @param mp
>> + * The packets mempool.
>> + * @param mbufs
>> + * The packets mbufs array to be freed.
>> + * @param n
>> + * Number of packets.
>> + */
>> +static inline void rte_pktmbuf_free_bulk(struct rte_mempool *mp,
>> + struct rte_mbuf **mbufs, unsigned n)
>> +{
>> + struct rte_mbuf *mbuf, *m_next;
>> + unsigned i;
>> + for (i = 0; i < n; ++i) {
>> + mbuf = mbufs[i];
>> + __rte_mbuf_sanity_check(mbuf, 1);
>> +
>> + mbuf = mbuf->next;
>> + while (mbuf != NULL) {
>> + m_next = mbuf->next;
>> + rte_pktmbuf_free_seg(mbuf);
>> + mbuf = m_next;
>> + }
>> + }
>> + rte_mempool_put_bulk(mp, (void * const *)mbufs, n);
>> +}
>
> The mbufs may come from different pools. You need to handle that.
>
As Stephen pointed mbufs can be from different mempools. But still can
benefit from bulk allocation part of your patch, would you mind
separating patches for alloc and free?
Thanks,
ferruh
next prev parent reply other threads:[~2017-01-11 17:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 21:50 Sergey Vyazmitinov
2017-01-11 10:39 ` Ananyev, Konstantin
2017-01-11 16:17 ` Stephen Hemminger
2017-01-11 16:38 ` Olivier MATZ
2017-01-11 17:00 ` Ferruh Yigit [this message]
2017-01-11 17:28 ` Ananyev, Konstantin
2017-01-11 17:35 ` Stephen Hemminger
2017-01-11 17:43 ` Ananyev, Konstantin
2017-01-11 17:47 ` Ferruh Yigit
2017-01-11 18:25 ` Ananyev, Konstantin
2017-01-11 18:41 ` Ferruh Yigit
2017-01-11 18:56 ` Stephen Hemminger
2017-01-16 7:39 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe15a2b1-b7a4-537a-e779-cb06954a23b6@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=s.vyazmitinov@brain4net.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).