DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Nicolas Chautru <nicolas.chautru@intel.com>, dev@dpdk.org
Cc: hemant.agrawal@nxp.com, hernan.vargas@intel.com
Subject: Re: [PATCH v1 1/1] bbdev: extend range of allocation function
Date: Fri, 2 Jun 2023 09:56:14 +0200	[thread overview]
Message-ID: <fedf4153-059b-b53b-c71d-4efc2cb18dc0@redhat.com> (raw)
In-Reply-To: <20230602020423.426465-2-nicolas.chautru@intel.com>



On 6/2/23 04:04, Nicolas Chautru wrote:
> Realigning the argument to unsigned int to
> align with number support by underlying
> rte_mempool_get_bulk function.
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>   lib/bbdev/rte_bbdev_op.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h
> index 96a390cd9b..9353fd588b 100644
> --- a/lib/bbdev/rte_bbdev_op.h
> +++ b/lib/bbdev/rte_bbdev_op.h
> @@ -982,7 +982,7 @@ rte_bbdev_op_pool_create(const char *name, enum rte_bbdev_op_type type,
>    */
>   static inline int
>   rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
> -		struct rte_bbdev_enc_op **ops, uint16_t num_ops)
> +		struct rte_bbdev_enc_op **ops, unsigned int num_ops)
>   {
>   	struct rte_bbdev_op_pool_private *priv;
>   
> @@ -1013,7 +1013,7 @@ rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
>    */
>   static inline int
>   rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
> -		struct rte_bbdev_dec_op **ops, uint16_t num_ops)
> +		struct rte_bbdev_dec_op **ops, unsigned int num_ops)
>   {
>   	struct rte_bbdev_op_pool_private *priv;

Isn't it breaking the ABI?

> @@ -1045,7 +1045,7 @@ rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
>   __rte_experimental
>   static inline int
>   rte_bbdev_fft_op_alloc_bulk(struct rte_mempool *mempool,
> -		struct rte_bbdev_fft_op **ops, uint16_t num_ops)
> +		struct rte_bbdev_fft_op **ops, unsigned int num_ops)
>   {
>   	struct rte_bbdev_op_pool_private *priv;
>   


  parent reply	other threads:[~2023-06-02  7:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-02  2:04 [PATCH v1 0/1] bbdev: extend range for alloc function Nicolas Chautru
2023-06-02  2:04 ` [PATCH v1 1/1] bbdev: extend range of allocation function Nicolas Chautru
2023-06-02  4:23   ` Hemant Agrawal
2023-06-02  7:56   ` Maxime Coquelin [this message]
2023-06-02 14:17     ` Chautru, Nicolas
2023-06-05 19:08       ` Maxime Coquelin
2023-07-06  9:12   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fedf4153-059b-b53b-c71d-4efc2cb18dc0@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=hernan.vargas@intel.com \
    --cc=nicolas.chautru@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).