From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 01/17] qede/base: update base driver
Date: Fri, 16 Sep 2016 13:48:37 +0100 [thread overview]
Message-ID: <fffce954-ae43-78d6-7112-c340f3da2ac0@intel.com> (raw)
In-Reply-To: <1472279188-24569-2-git-send-email-rasesh.mody@qlogic.com>
Hi Rasesh,
On 8/27/2016 7:26 AM, Rasesh Mody wrote:
> This patch updates the base driver and incorporates neccessary changes
> required to bring in the new firmware 8.10.9.0.
>
> In addition, it would allow driver to add new functionalities that might
> be needed in future.
>
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> ---
<...>
> 65 files changed, 14653 insertions(+), 8536 deletions(-)
<...>
Sorry for late review.
This is base driver update, but still a big single patch with 14K lines
insertions, it is too hard to both review or contribute.
Is it possible to split patch into more smaller ones, ideally it should
be one patch for one feature/fix, but please do whatever can be done.
I can see there are some big chunk of whitespace updates, or new files
for debug (hsi_debug_tools.h), those can be easy to target.
Thanks,
ferruh
next prev parent reply other threads:[~2016-09-16 12:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 6:26 [dpdk-dev] [PATCH 00/17] update qede pmd to 1.2.0.1 Rasesh Mody
2016-08-27 6:26 ` [dpdk-dev] [PATCH 01/17] qede/base: update base driver Rasesh Mody
2016-09-16 12:48 ` Ferruh Yigit [this message]
2016-09-16 16:06 ` Mody, Rasesh
2016-09-28 13:25 ` Ferruh Yigit
2016-08-27 6:26 ` [dpdk-dev] [PATCH 02/17] qede/base: add the driver support for the MFW crash dump Rasesh Mody
2016-08-27 6:26 ` [dpdk-dev] [PATCH 03/17] qede: enable support for unequal number of RX/TX queues Rasesh Mody
2016-08-27 6:26 ` [dpdk-dev] [PATCH 04/17] qede: fix port (re)configuration issue Rasesh Mody
2016-08-27 6:26 ` [dpdk-dev] [PATCH 05/17] qede/base: allow MTU change via vport-update Rasesh Mody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fffce954-ae43-78d6-7112-c340f3da2ac0@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=rasesh.mody@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).