From: "Wiles, Keith" <keith.wiles@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"moving@dpdk.org" <moving@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-moving] Proposal a Committer model
Date: Thu, 17 Nov 2016 14:05:33 +0000 [thread overview]
Message-ID: <591DFA12-C6F8-4384-B241-40C84A11C100@intel.com> (raw)
In-Reply-To: <1916104.Dc8TqC8RB2@xps13>
> On Nov 17, 2016, at 7:43 AM, Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>
> 2016-11-17 09:27, Mcnamara, John:
>> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
>>> I believe the multi-committers model may not fix current consensus
>>> slowness issue. Instead, if we are focusing on reducing the workload of
>>> Thomas, then I think git pull request based scheme will reduce the
>>> workload.
>>
>> So, something like a Gerrit model?
>
> No, the mechanics of committing is not time consuming.
The time consuming part is the reviewing the patch and using Gerrit does attempt to make sure the reviewers are emailed directly. This to me helps to require reviews as sometimes the huge email volume on the list is difficult to see patches someone needs to review.
I would much more prefer one email (from Gerrit) per patch set instead of 10 or 30 emails in some cases for a single email. Using gerrit also combines the patch review comments, patchwork and email list into one tool plus it can kick off the build and checkpatch processes.
Having a Gerrit model is not a bad process model and allows for multiple committers. I know it is a new tool and it is pretty simple to use.
>
Regards,
Keith
next prev parent reply other threads:[~2016-11-17 14:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 23:35 Mcnamara, John
2016-11-16 10:45 ` Thomas Monjalon
2016-11-16 15:13 ` Bruce Richardson
2016-11-16 16:23 ` Wiles, Keith
2016-11-16 19:42 ` Jerin Jacob
2016-11-17 9:27 ` Mcnamara, John
2016-11-17 13:43 ` Thomas Monjalon
2016-11-17 14:05 ` Wiles, Keith [this message]
2016-11-18 10:45 ` Hemant Agrawal
2016-11-18 17:14 ` Stephen Hemminger
2016-11-17 22:57 ` Ed Warnicke
2016-11-18 10:45 ` Hemant Agrawal
2016-11-16 20:16 ` Dave Neary
2016-11-17 8:14 ` Mcnamara, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=591DFA12-C6F8-4384-B241-40C84A11C100@intel.com \
--to=keith.wiles@intel.com \
--cc=bruce.richardson@intel.com \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=john.mcnamara@intel.com \
--cc=moving@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).