From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama50.ecl.ntt.co.jp (tama50.ecl.ntt.co.jp [129.60.39.147]) by dpdk.org (Postfix) with ESMTP id 1480F4C91 for ; Fri, 28 Dec 2018 05:29:21 +0100 (CET) Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id wBS4TKJi022580; Fri, 28 Dec 2018 13:29:20 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 24F0DEA7AE4; Fri, 28 Dec 2018 13:29:20 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 1A740EA7A9A; Fri, 28 Dec 2018 13:29:20 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 15A1A40059C; Fri, 28 Dec 2018 13:29:20 +0900 (JST) References: <201812270904.wBR940SU024668@imss04.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: <06561a4d-cef5-3846-5053-181a0fa34108@lab.ntt.co.jp> Date: Fri, 28 Dec 2018 13:26:51 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201812270904.wBR940SU024668@imss04.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: x-fn-spp@sl.ntt-tx.co.jp, spp@dpdk.org Cc: ferruh.yigit@intel.com X-TM-AS-MML: disable Subject: Re: [spp] [PATCH] spp_vf: fix to generate debug information X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Dec 2018 04:29:22 -0000 On 2018/12/27 18:04, x-fn-spp@sl.ntt-tx.co.jp wrote: > From: Hideyuki Yamashita > > This patch changes 'inline' declaration to 'static inline'or 'extern > inline' to be able to generate debug information. Thank you for your contribution, applied. > > Signed-off-by: Hideyuki Yamashita > Signed-off-by: Naoki Takada > --- > src/vf/common/command_dec.c | 4 ++-- > src/vf/common/spp_port.c | 6 +++--- > src/vf/common/string_buffer.c | 4 ++-- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/vf/common/command_dec.c b/src/vf/common/command_dec.c > index 5b6ffcf..b328ca8 100644 > --- a/src/vf/common/command_dec.c > +++ b/src/vf/common/command_dec.c > @@ -212,7 +212,7 @@ spp_convert_component_type(const char *type_str) > } > > /* set decode error */ > -inline int > +static inline int > set_decode_error(struct spp_command_decode_error *error, > const int error_code, const char *error_name) > { > @@ -225,7 +225,7 @@ set_decode_error(struct spp_command_decode_error *error, > } > > /* set decode error */ > -inline int > +static inline int > set_string_value_decode_error(struct spp_command_decode_error *error, > const char *value, const char *error_name) > { > diff --git a/src/vf/common/spp_port.c b/src/vf/common/spp_port.c > index d7d374e..fd76d79 100644 > --- a/src/vf/common/spp_port.c > +++ b/src/vf/common/spp_port.c > @@ -57,7 +57,7 @@ spp_port_ability_init(void) > } > > /* Get information of port ability. */ > -inline void > +extern inline void > spp_port_ability_get_info( > int port_id, enum spp_port_rxtx rxtx, > struct spp_port_ability **info) > @@ -365,7 +365,7 @@ port_ability_each_operation(uint16_t port_id, > } > > /* Wrapper function for rte_eth_rx_burst(). */ > -inline uint16_t > +extern inline uint16_t > spp_eth_rx_burst( > uint16_t port_id, uint16_t queue_id __attribute__ ((unused)), > struct rte_mbuf **rx_pkts, const uint16_t nb_pkts) > @@ -387,7 +387,7 @@ spp_eth_rx_burst( > } > > /* Wrapper function for rte_eth_tx_burst(). */ > -inline uint16_t > +extern inline uint16_t > spp_eth_tx_burst( > uint16_t port_id, uint16_t queue_id __attribute__ ((unused)), > struct rte_mbuf **tx_pkts, uint16_t nb_pkts) > diff --git a/src/vf/common/string_buffer.c b/src/vf/common/string_buffer.c > index acf0f81..768dd3a 100644 > --- a/src/vf/common/string_buffer.c > +++ b/src/vf/common/string_buffer.c > @@ -13,14 +13,14 @@ > #define RTE_LOGTYPE_SPP_STRING_BUFF RTE_LOGTYPE_USER1 > > /* get message buffer capacity */ > -inline size_t > +static inline size_t > strbuf_get_capacity(const char *strbuf) > { > return *((const size_t *)(strbuf - sizeof(size_t))); > } > > /* re-allocate message buffer */ > -inline char* > +static inline char* > strbuf_reallocate(char *strbuf, size_t required_len) > { > size_t new_cap = strbuf_get_capacity(strbuf) * 2; > -- Yasufumi Ogawa NTT Network Service Systems Labs