From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mogw1013.ocn.ad.jp (mogw1013.ocn.ad.jp [153.149.231.19]) by dpdk.org (Postfix) with ESMTP id ED2AC5B38 for ; Sat, 24 Nov 2018 13:57:38 +0100 (CET) Received: from mf-smf-unw001c2 (mf-smf-unw001c2.ocn.ad.jp [153.138.219.67]) by mogw1013.ocn.ad.jp (Postfix) with ESMTP id 0F0C1A0031D; Sat, 24 Nov 2018 21:57:37 +0900 (JST) Received: from ocn-vc-mts-104c1.ocn.ad.jp ([153.138.237.81]) by mf-smf-unw001c2 with ESMTP id QXTrglN6jPIinQXVAgIBY9; Sat, 24 Nov 2018 21:57:36 +0900 Received: from smtp.ocn.ne.jp ([153.149.227.165]) by ocn-vc-mts-104c1.ocn.ad.jp with ESMTP id QXVAgFqvkq2v1QXVAgyLXI; Sat, 24 Nov 2018 21:57:36 +0900 Received: from mugwort.local (p3371093-ipngn19601marunouchi.tokyo.ocn.ne.jp [153.228.164.93]) by smtp.ocn.ne.jp (Postfix) with ESMTPA; Sat, 24 Nov 2018 21:57:36 +0900 (JST) To: x-fn-spp@sl.ntt-tx.co.jp Cc: ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp, spp@dpdk.org References: <201811070507.wA757WWo008866@imss03.silk.ntt-tx.co.jp> <201811210652.wAL6qKRn011045@imss04.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: <10f6777b-9af0-9705-bed4-054e7fd9a8ac@juno.ocn.ne.jp> Date: Sat, 24 Nov 2018 21:57:36 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <201811210652.wAL6qKRn011045@imss04.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [spp] [PATCH v2 0/6] Replace deprecated APIs X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Nov 2018 12:57:39 -0000 >>>From DPDK 18.08, following APIs become deprecated and will be deleted in 18.11. > - rte_eth_dev_attach() > - rte_eth_dev_detach() > > It is recommended to use followings. > - rte_eth_dev_attach() should be replaced by rte_eal_hotplug_add(). > - rte_eth_dev_detach() should be replaced by rte_eal_hotplug_remove(). > > This series of patches is to update for the changes. > - Add dev_attach_by_devargs() as replacement of rte_eth_dev_attach(). This function > calls rte_eal_hotplug_add() to hotplug device for given name "devargs",and returns > newly allocated dpdk port_id. > - Add dev_detach_by_port_id() as replacement of rte_eth_dev_detach(). This function > calls rte_eal_hotplug_remove() to detach device for given port_id. > - Replace rte_eth_dev_attach() in spp_nfv and spp_vf with dev_attach_by_devargs(). > - Replace rte_eth_dev_attach() in spp_nfv and spp_vf with dev_detach_by_port_id(). Hideyuki, Your patches cause compile errors because DPDK APIs you use instead of depricated APIs are still not stable. You should add `-DALLOW_EXPERIMENTAL_API` to CFLAG option in each of Makefiles of SPP processes. I already fixed this bug while I checked your patches. I would like to send patches to fix this bug. Thanks, Yasufumi > > Hideyuki Yamashita (6): > shared: add dev_attach_by_devargs > spp_nfv: replace deprecated rte_eth_dev_attach > spp_vf: replace deprecated rte_eth_dev_attach > shared: add dev_detach_by_port_id > spp_nfv: replace deprecated rte_eth_dev_detach > spp_vm: replace deprecated rte_eth_dev_detach > > src/nfv/nfv.c | 18 +++++-------- > src/shared/common.c | 64 +++++++++++++++++++++++++++++++++++++++++++++ > src/shared/common.h | 29 ++++++++++++++++++++ > src/vf/spp_vf.c | 4 +-- > src/vm/main.c | 4 +-- > 5 files changed, 102 insertions(+), 17 deletions(-) >