Soft Patch Panel
 help / color / mirror / Atom feed
From: ogawa.yasufumi@lab.ntt.co.jp
To: ferruh.yigit@intel.com, spp@dpdk.org, ogawa.yasufumi@lab.ntt.co.jp
Subject: [spp] [PATCH 1/3] shared: add util functions to set log level
Date: Fri, 21 Dec 2018 13:10:39 +0900	[thread overview]
Message-ID: <1545365441-9864-2-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> (raw)
In-Reply-To: <1545365441-9864-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp>

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

This update is to add utility functions to change the log level of
`user*` in more simple way. If you change the level of RTE_LOGTYPE_USER1
to RTE_LOG_DEBUG, simply call `set_user_log_debug(1)`. You can also
change to any of log level like as `set_user_log_level(1, RTE_LOG_INFO)`.

Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
 src/shared/common.c | 37 ++++++++++++++++++++++++++++++++++++-
 src/shared/common.h |  6 ++++++
 2 files changed, 42 insertions(+), 1 deletion(-)

diff --git a/src/shared/common.c b/src/shared/common.c
index 0e32fa6..8837ff9 100644
--- a/src/shared/common.c
+++ b/src/shared/common.c
@@ -66,6 +66,41 @@ check_all_ports_link_status(struct port_info *ports, uint16_t port_num,
 }
 
 /**
+ * Set log level of type RTE_LOGTYPE_USER* to given level, for instance,
+ * RTE_LOG_INFO or RTE_LOG_DEBUG.
+ *
+ * This function is typically used to output debug log as following.
+ *
+ *   #define RTE_LOGTYPE_APP RTE_LOGTYPE_USER1
+ *   ...
+ *   set_user_log_level(1, RTE_LOG_DEBUG);
+ *   ...
+ *   RTE_LOG(APP, DEBUG, "Your debug log...");
+ */
+int
+set_user_log_level(int num_user_log, uint32_t log_level)
+{
+	char userlog[8];
+
+	if (num_user_log < 1 || num_user_log > 8)
+		return -1;
+
+	memset(userlog, '\0', sizeof(userlog));
+	sprintf(userlog, "user%d", num_user_log);
+
+	rte_log_set_level(rte_log_register(userlog), log_level);
+	return 0;
+}
+
+/* Set log level of type RTE_LOGTYPE_USER* to RTE_LOG_DEBUG. */
+int
+set_user_log_debug(int num_user_log)
+{
+	set_user_log_level(num_user_log, RTE_LOG_DEBUG);
+	return 0;
+}
+
+/**
  * Initialise an individual port:
  * - configure number of rx and tx rings
  * - set up each rx ring, to pull from the main mbuf pool
@@ -538,7 +573,7 @@ dev_detach_by_port_id(uint16_t port_id)
 
 	if (rte_eth_devices[port_id].data == NULL) {
 		RTE_LOG(INFO, APP,
-			"rte_eth_devices[%d].data is  NULL\n", port_id);
+			"rte_eth_devices[%"PRIu16"].data is  NULL\n", port_id);
 		return 0;
 	}
 	dev_flags = rte_eth_devices[port_id].data->dev_flags;
diff --git a/src/shared/common.h b/src/shared/common.h
index 09dbf8a..326343e 100644
--- a/src/shared/common.h
+++ b/src/shared/common.h
@@ -188,6 +188,12 @@ get_null_pmd_name(int id)
 	return buffer;
 }
 
+/* Set log level of type RTE_LOGTYPE_USER* to given level. */
+int set_user_log_level(int num_user_log, uint32_t log_level);
+
+/* Set log level of type RTE_LOGTYPE_USER* to RTE_LOG_DEBUG. */
+int set_user_log_debug(int num_user_log);
+
 void check_all_ports_link_status(struct port_info *ports, uint16_t port_num,
 		uint32_t port_mask);
 
-- 
2.7.4

  reply	other threads:[~2018-12-21  4:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-21  4:10 [spp] [PATCH 0/3] Add utility functions for debug log ogawa.yasufumi
2018-12-21  4:10 ` ogawa.yasufumi [this message]
2018-12-21  4:10 ` [spp] [PATCH 2/3] primary: change dynamic log level to RTE_LOG_DEBUG ogawa.yasufumi
2018-12-21  4:10 ` [spp] [PATCH 3/3] spp_nfv: " ogawa.yasufumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1545365441-9864-2-git-send-email-ogawa.yasufumi@lab.ntt.co.jp \
    --to=ogawa.yasufumi@lab.ntt.co.jp \
    --cc=ferruh.yigit@intel.com \
    --cc=spp@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).