Soft Patch Panel
 help / color / mirror / Atom feed
From: ogawa.yasufumi@lab.ntt.co.jp
To: ferruh.yigit@intel.com, spp@dpdk.org, ogawa.yasufumi@lab.ntt.co.jp
Subject: [spp] [PATCH 0/4] Fix bug of fixing slow command reply
Date: Tue, 15 Jan 2019 12:29:04 +0900	[thread overview]
Message-ID: <1547522948-10285-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> (raw)

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

This update is to fix incorrect fixing of slow command reply for spp_vf
and spp_mirror. It was applied as following updates, but not fixed the
problem.

* ab5183201c02 ("spp_vf: add sleep after disconnection detection")
* 5eea2dfa5420 ("fix slow response of command")

To reduce time for making command reply, replace sleep(1) to usleep(100)
for, and add another sleep(1) to avoid sending too much requests if sock
is closed and retry in previous patches. However, response is still slow
because the place of added sleep(1) is incorrect.

This series of update is to fix the problem. It also includes a
definition of interval time `CONN_RETRY_USEC` to be configured in micro
sec.

Yasufumi Ogawa (4):
  shared: define interval time to retry connection
  primary: change interval to retry connection
  spp_nfv: change interval to retry connection
  spp_vf: fix bug of fixing slow command reply

 src/nfv/main.c               | 2 +-
 src/primary/main.c           | 2 +-
 src/shared/common.h          | 3 +++
 src/vf/common/command_conn.c | 4 ++++
 src/vf/common/command_proc.c | 9 ++++-----
 src/vf/spp_vf.c              | 4 +---
 6 files changed, 14 insertions(+), 10 deletions(-)

-- 
2.17.1

             reply	other threads:[~2019-01-15  3:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15  3:29 ogawa.yasufumi [this message]
2019-01-15  3:29 ` [spp] [PATCH 1/4] shared: define interval time to retry connection ogawa.yasufumi
2019-01-15  3:29 ` [spp] [PATCH 2/4] primary: change interval " ogawa.yasufumi
2019-01-15  3:29 ` [spp] [PATCH 3/4] spp_nfv: " ogawa.yasufumi
2019-01-15  3:29 ` [spp] [PATCH 4/4] spp_vf: fix bug of fixing slow command reply ogawa.yasufumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1547522948-10285-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp \
    --to=ogawa.yasufumi@lab.ntt.co.jp \
    --cc=ferruh.yigit@intel.com \
    --cc=spp@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).